Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

remove wideButton class from the buttons on the Edit Bookmark dialog #6400

Closed
luixxiul opened this issue Dec 23, 2016 · 3 comments
Closed

remove wideButton class from the buttons on the Edit Bookmark dialog #6400

luixxiul opened this issue Dec 23, 2016 · 3 comments
Assignees
@luixxiul
Labels
feature/bookmarks misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Milestone
0.15.300 (Frozen,...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Dec 23, 2016 •
edited
Loading

Test plan

  1. Click the star icon on about:bookmarks
  2. Make sure the width of the buttons are same as those on the picture for "test plan 2" on Refactor addEditBookmarkHanger.js with commonForm #8136 (comment)

Describe the issue you encountered:
#6372 (comment)

For example, we could remove wideButton class from the buttons on the Edit Bookmark dialog to make it into like this (which I prefer actually):
screenshot 2016-12-22 12 03 14

Expected behavior:

  • Brave Version (revision SHA): 93b7c31

  • Any related issues:
@luixxiul
Copy link
Contributor Author

This is a regression I introduced: 1df8dc3 of #6000

wideButton is no longer necessary as the min-width of the button was set with #6387

@luixxiul luixxiul added this to the 0.13.0 milestone Dec 24, 2016
@bbondy
Copy link
Member

bbondy commented Dec 26, 2016

I don't think this needs to be tracked in 0.13.0 but please let me know why if so.

@bbondy bbondy removed this from the 0.13.0 milestone Dec 26, 2016
@luixxiul luixxiul added this to the contributor backlog milestone Jan 6, 2017
@luixxiul luixxiul mentioned this issue Jan 13, 2017
Merged
4 tasks
@luixxiul luixxiul removed this from the contributor backlog milestone Apr 30, 2017
@luixxiul luixxiul self-assigned this Apr 30, 2017
@luixxiul
Copy link
Contributor Author

Fixed with #8443 (#8136)

@luixxiul luixxiul added this to the 0.15.2 milestone Apr 30, 2017
This was referenced May 2, 2017
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Jun 3, 2017
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/bookmarks misc/button QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/include
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
4 participants
@bbondy @alexwykoff @luixxiul @srirambv