Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Font-weight was globaly set to 400 #6149

Closed
luixxiul opened this issue Dec 12, 2016 · 1 comment
Closed

Font-weight was globaly set to 400 #6149

luixxiul opened this issue Dec 12, 2016 · 1 comment
Labels
design A design change, especially one which needs input from the design team. stale

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered:
https://github.com/brave/browser-laptop/pull/6000/files#diff-b79e96c438a5b97dc31f04f68d4817a7R12

This reset every font-weight to 400, which results headings are no longer bolded unless specified.

For example, in a commit of #6047 the headings like "Enter your recovery key below" is not bolded.

screenshot 2016-12-10 14 35 58

Expected behavior:
If it is not expected, either 1) remove the line or 2) sprcify font-weight for the headings globally
@luixxiul luixxiul added the design A design change, especially one which needs input from the design team. label Dec 12, 2016
@luixxiul
Copy link
Contributor Author

CC @bradleyrichter for thoughts

@luixxiul luixxiul mentioned this issue Dec 16, 2016
Closed
@bsclifton bsclifton added this to the Triage Backlog milestone Nov 27, 2017
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team. stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@luixxiul @bsclifton