Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Newtab should not have an empty favicon #5776

Closed
srirambv opened this issue Nov 21, 2016 · 3 comments · Fixed by #5845
Closed

Newtab should not have an empty favicon #5776

srirambv opened this issue Nov 21, 2016 · 3 comments · Fixed by #5845

Comments

@srirambv
Copy link
Collaborator

srirambv commented Nov 21, 2016

Did you search for similar issues before submitting this one?
Yes

Expected behavior:
Newtab should not have an empty favicon

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version:
    0.12.10 RC1

  • Screenshot if needed:
    image

    edit: both newtab and about:blank

  • Any related issues:

@bsclifton
Copy link
Member

bsclifton commented Nov 22, 2016

Thinking about this, the solution might be as easy as removing the icon from the about-blank.html / about-newtab.html 😄

Let's just remove the icon for these two pages altogether

@bbondy
Copy link
Member

bbondy commented Nov 22, 2016

@bsclifton sounds like a good plan

@luixxiul
Copy link
Contributor

Test plan: automated test should pass

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.