Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about:newtab - load images remotely #5396

Closed
bsclifton opened this issue Nov 4, 2016 · 1 comment
Closed

about:newtab - load images remotely #5396

bsclifton opened this issue Nov 4, 2016 · 1 comment
Assignees
@bsclifton
Labels
feature/newtab QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Milestone
0.12.9dev

Comments

@bsclifton
Copy link
Member

The images that are shown in about:newtab should be decoupled from Brave. It would be good to provide one fallback image but otherwise try to load remotely.

The image JSON can remain inside our project with URLs pointing back at the remote images. Brave will automatically cache each image (respecting the cache header), so no need to store it locally.
@bsclifton bsclifton added this to the 0.12.9dev milestone Nov 4, 2016
@bsclifton bsclifton self-assigned this Nov 4, 2016
@bsclifton
Copy link
Member Author

bsclifton commented Nov 4, 2016 •
edited
Loading

Fixed with fd3e857

Which is part of #5301

This was referenced Nov 10, 2016
Closed
Closed
Closed
Closed
Closed
Closed
@luixxiul luixxiul mentioned this issue Nov 14, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
feature/newtab QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64
Projects
None yet
Milestone
0.12.9dev
Development

No branches or pull requests
4 participants
@alexwykoff @luixxiul @bsclifton @srirambv