Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

[support] invalid homepage URL causes 'uncaught typeerror' #4974

Closed
diracdeltas opened this issue Oct 20, 2016 · 2 comments
Closed

[support] invalid homepage URL causes 'uncaught typeerror' #4974

diracdeltas opened this issue Oct 20, 2016 · 2 comments

Comments

@diracdeltas
Copy link
Member

diracdeltas commented Oct 20, 2016

from https://linkbubble.zendesk.com/agent/tickets/6219:

  1. set homepage to https://brave.com;https://google.com.vn
  2. restart browser

reporter says browser is stuck in a blank state, but i only see this error in the console:

urlutil.js:158Uncaught TypeError: Failed to construct 'URL': Invalid URL
@srirambv
Copy link
Collaborator

The issue is when you set the homepage as https://brave.com;https://google.com.vn and then change the setting to launch brave with homepage.

homepageerror

@srirambv srirambv reopened this Oct 20, 2016
@diracdeltas
Copy link
Member Author

this didn't make it into the build either. we should keep issues closed when the code exists on master even if the last RC build doesn’t have the fix

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants