Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Move bookmark hanger arrow now that reload is on about pages #4923

Closed
jkup opened this issue Oct 18, 2016 · 0 comments
Closed

Move bookmark hanger arrow now that reload is on about pages #4923

jkup opened this issue Oct 18, 2016 · 0 comments
Assignees
@jkup
Labels
design A design change, especially one which needs input from the design team. feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64
Milestone
0.12.6dev

Comments

@jkup
Copy link
Contributor

jkup commented Oct 18, 2016

The current bookmark door hanger code relies on about: pages not having the reload / stop buttons but now that darkdh@61994b5 has shipped they do. We can get rid of the withStopButton class and move the default spacing to compensate for another button.
@jkup jkup added design A design change, especially one which needs input from the design team. feature/bookmarks labels Oct 18, 2016
@jkup jkup added this to the 0.12.6dev milestone Oct 18, 2016
@jkup jkup self-assigned this Oct 18, 2016
@jkup jkup mentioned this issue Oct 18, 2016
Merged
4 tasks
This was referenced Oct 20, 2016
Closed
Closed
@alexwykoff alexwykoff mentioned this issue Oct 22, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jkup jkup

Labels
design A design change, especially one which needs input from the design team. feature/bookmarks QA/checked-Linux QA/checked-macOS QA/checked-Win64
Projects
None yet
Milestone
0.12.6dev
Development

No branches or pull requests
3 participants
@jkup @alexwykoff @srirambv