This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Clear state if clear autofill data when shutdown. #4827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because we won't receive personal-data-changed on shutdown fix brave#4818 Auditors: @bridiver Test Plan: 1. Add autofill data entries in about:autofill 2. Turn on clear "Autofill data" when closing brave in about:preferences#security 3. Restart brave 4. There shouldn't be anything left in about:autofill
bridiver
reviewed
Oct 15, 2016
| @@ -252,6 +252,11 @@ module.exports.cleanAppData = (data, isShutdown) => { | |||
| const clearAutofillData = isShutdown && getSetting(settings.SHUTDOWN_CLEAR_AUTOFILL_DATA) === true | |||
| if (clearAutofillData) { | |||
| autofill.clearAutofillData() | |||
| const date = new Date().getTime() | |||
There was a problem hiding this comment.
this works, but fyi you can just delete it because it will be-readded from the default session data
|
++ |
This was referenced Oct 16, 2016
102 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).because we won't receive personal-data-changed on shutdown
fix #4818
Auditors: @bridiver
Test Plan: