Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

zoom in / out / reset (with numpad) not working #4815

Closed
luixxiul opened this issue Oct 15, 2016 · 14 comments
Closed

zoom in / out / reset (with numpad) not working #4815

luixxiul opened this issue Oct 15, 2016 · 14 comments
Labels
feature/keyboard-shortcuts fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. stale upstream wontfix

Comments

@luixxiul
Copy link
Contributor

Describe the issue you encountered: zoom in / out shortcut stopped working. Removing brave folder does not help.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10
  • Brave Version: 0.12.5 RC1
  • Any related issues:
@luixxiul luixxiul added this to the 0.12.5dev milestone Oct 15, 2016
@luixxiul luixxiul mentioned this issue Oct 15, 2016
Closed
@luixxiul
Copy link
Contributor Author

zooming in / out with the numpad stopped working.

@luixxiul luixxiul changed the title regression: zoom in / out shortcut stopped working regression: zoom in / out with numpad stopped working Oct 15, 2016
@bbondy
Copy link
Member

bbondy commented Oct 15, 2016

-, +, and 0 on top of keyboard on macOS and Windows. This is only on bigger keyboards on the right? Moving to 0.12.6.

@bbondy bbondy modified the milestones: 0.12.6dev, 0.12.5dev Oct 15, 2016
@cndouglas
Copy link

Related issue: #3040

@bbondy
Copy link
Member

bbondy commented Oct 18, 2016 •
edited
Loading

@bsclifton do you have a full keyboard and could you take?

@bsclifton
Copy link
Member

Yup- I'm on it 😄

@bsclifton
Copy link
Member

bsclifton commented Oct 18, 2016 •
edited
Loading

Works great on macOS (both regular +/- and numpad)

Reproduced problem on Windows 10 w/ numpad. Digging in more...

@bsclifton
Copy link
Member

Root cause seems to be in electron (not supported yet)...
electron/electron#3332

I'm going to remove the regression label (please add back if I am incorrect in removing)

There might be a work-around for this; I'll look at implementing that 😄

@bsclifton bsclifton changed the title regression: zoom in / out with numpad stopped working zoom in / out / reset (with numpad) not working Oct 19, 2016
@bsclifton bsclifton mentioned this issue Oct 19, 2016
Closed
@bsclifton
Copy link
Member

Moving to 0.12.7 since this is marked as not-blocking

@bsclifton bsclifton modified the milestones: 0.12.7dev, 0.12.6dev Oct 19, 2016
@bsclifton
Copy link
Member

@bbondy because this is a problem upstream, I'd like to propose moving it out of 0.12.7. It's still important, but seems it would need an electron change

@bbondy bbondy removed this from the 0.12.7dev milestone Oct 20, 2016
@bsclifton bsclifton removed their assignment Oct 23, 2016
@bsclifton bsclifton mentioned this issue Mar 1, 2017
Closed
@bsclifton
Copy link
Member

On Linux, user @SamClarke2012 reports that - and + on the numpad both work great (just not reset)

@bsclifton bsclifton added this to the 1.2.0 milestone Mar 2, 2017
@bsclifton bsclifton self-assigned this Mar 2, 2017
@bsclifton
Copy link
Member

bsclifton commented Mar 10, 2017 •
edited
Loading

@gsantner thanks for the feedback 😄 I removed the Windows tag since it happens for sure on Linux (and likely macOS, if you have a full extended keyboard)

@luixxiul
Copy link
Contributor Author

I cannot reproduce the issue on Windows 10.

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label May 28, 2017
@alexwykoff alexwykoff modified the milestones: 1.2.0, Backlog Nov 1, 2017
@luixxiul
Copy link
Contributor Author

Closing as stale.

@luixxiul luixxiul added the stale label Nov 18, 2017
@luixxiul luixxiul removed this from the Triage Backlog milestone Nov 18, 2017
@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label Nov 18, 2017
@bsclifton bsclifton mentioned this issue Aug 26, 2018
Closed
@bsclifton bsclifton added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. labels Aug 26, 2018
@bsclifton bsclifton removed their assignment Aug 26, 2018
@bsclifton
Copy link
Member

Verified fixed with brave-core

@abnerlee abnerlee mentioned this issue Jul 21, 2020
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
feature/keyboard-shortcuts fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. stale upstream wontfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@bbondy @alexwykoff @luixxiul @bsclifton @cndouglas