Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pocket: Closing currentTab crashes Brave #4699

Closed
jonathansampson opened this issue Oct 12, 2016 · 0 comments
Closed

Pocket: Closing currentTab crashes Brave #4699

jonathansampson opened this issue Oct 12, 2016 · 0 comments
Labels
crash feature/extensions QA/checked-macOS
Milestone
0.12.5dev

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Oct 12, 2016 •
edited
Loading

Describe the issue you encountered:
If you attempt to close the current tab with chrome.tabs.remove, you may cause Brave to crash.

Expected behavior:
Closing the current tab with chrome.tabs.remove results in another tab taking focus.

Platform: Windows 10

Brave Version: 0.12.4

Steps to reproduce:

  1. Navigate to about:extensions
  2. Right-click page, select Inspect Element, open Console
  3. Run chrome.tabs.getCurrent(tab=>chrome.tabs.remove([tab.id]))
  4. Observe crash

I'm currently working around this by creating a new active tab, and removing the target tab after 500ms.

  • Any related issues:
@jonathansampson jonathansampson added this to the 0.12.6dev milestone Oct 12, 2016
@luixxiul luixxiul added the crash label Oct 12, 2016
@bbondy bbondy modified the milestones: 0.12.5dev, 0.12.6dev Oct 14, 2016
This was referenced Oct 14, 2016
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
crash feature/extensions QA/checked-macOS
Projects
None yet
Milestone
0.12.5dev
Development

No branches or pull requests
4 participants
@jonathansampson @bbondy @alexwykoff @luixxiul