Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

The urlbar is really touchy and forcing errors #4584

Closed
alexwykoff opened this issue Oct 6, 2016 · 3 comments
Closed

The urlbar is really touchy and forcing errors #4584

alexwykoff opened this issue Oct 6, 2016 · 3 comments

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Oct 6, 2016

Did you search for similar issues before submitting this one?
Yes

Describe the issue you encountered:
When attempting to type in an autocomplete-available url, Brave is jumping ahead and filling in the value instead of waiting for me to hit enter. This is forcing errors where I have to correct the autocomplete.

Expected behavior:
Autocomplete should not inject characters unless I explicitly select the suggestion.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Tested on OS X
  • Brave Version:
    0.12.4 Preview3
  • Steps to reproduce:
    1. Try to type in 'youtube.com' by hand in the urlbar
  • Screenshot if needed:
    touchy_urlbar
  • Any related issues:
    I believe this may be a regression introduced by urlbar autocomplete suffix causing issues #4573

#4581
#4563
#3876

@bbondy
Copy link
Member

bbondy commented Oct 6, 2016

@diracdeltas I'm thinking this is probably related to the urlbar optimizations, I think it'd be best to move this out of 0.12.4 and back out the perf fix for now. Would you mind doing that if you confirm it's from your changset that I merged? Thanks!

@diracdeltas
Copy link
Member

@bbondy almost certainly and it was reverted last night

@diracdeltas
Copy link
Member

closed by 9e98154

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants