This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
reset reconciliation time when publisher window is closed #4516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. always make this check on startup, settings changes, etc. 2. rather than look for a time in the past (after all, the user could just be a day late doing stuff), look to see if the reconciliation stamp is at the end of the publisher window (the window consists of N frames, each of duration M… N=30, M=1day) fixes #4058 auditor: @ayumi
ayumi
reviewed
Oct 4, 2016
| @@ -458,17 +458,19 @@ var initialize = (paymentsEnabled, reason) => { | |||
| // Scenario: User enables Payments, disables it, waits 30+ days, then | |||
| // enables it again -> reconcileStamp is in the past. | |||
| // In this case reset reconcileStamp to the future. | |||
| if (reason === 'changeSettingPaymentsEnabled') { | |||
There was a problem hiding this comment.
as a result of this PR we can remove changeSettingPaymentsEnabled at ln 134 and the reason arg in this function initialize(paymentsEnabled,reason) (it was added to fix this)
There was a problem hiding this comment.
true. it is used only in one place. remove it?
|
tried it out / lgtm 🎁 |
This was referenced Oct 5, 2016
This was referenced Oct 6, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test plan:
ledger-state.jsonto change the line start starts as"reconcileStamp": 14...to change the4to a34, start the browser
auditor: @ayumi
fixes #4058