Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

tracking issue: regressions caused by commit 35de6cf #4267

Closed
luixxiul opened this issue Sep 24, 2016 · 4 comments
Closed

tracking issue: regressions caused by commit 35de6cf #4267

luixxiul opened this issue Sep 24, 2016 · 4 comments
Assignees
Milestone

Comments

@luixxiul
Copy link
Contributor

#4261
#4262
#4263

Per @bsclifton on #4261 (comment)

Confirmed it works if I revert 35de6cf. Checked with @bridiver and there wasn't any intended change. Will continue investigating tomorrow

35de6cf has been reverted for a moment.

@luixxiul luixxiul added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Sep 24, 2016
@luixxiul luixxiul added this to the 0.12.3dev milestone Sep 24, 2016
@bbondy
Copy link
Member

bbondy commented Sep 24, 2016

was reverted here:
1d65e0b

@bbondy bbondy closed this as completed Sep 24, 2016
@luixxiul
Copy link
Contributor Author

luixxiul commented Sep 25, 2016

#4250 is the PR which 35de6cf merged.

@bsclifton
Copy link
Member

may have also broke #4246 (works after revert)

@luixxiul
Copy link
Contributor Author

luixxiul commented Sep 26, 2016

#4262: I noticed later that NoScript could not be disabled not only at brianbondy.com but also all websites.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants