This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Reorder Brave Payments buttons to improve 1st-time flow #4040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkup
added
the
design
|
nice work! |
|
@diracdeltas or @bbondy whenever either of you get a minute can I get a quick review on this? Thanks! |
|
++ |
This was referenced Sep 22, 2016
This was referenced Sep 22, 2016
This was referenced Sep 24, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git rebase -ito squash commits (if needed).Fix #3963
Test Plan:
Make sure the new Payments tab looks like @bradleyrichter's spec in #3963
Screenshot of this branch here for convenience:
