Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

about:history no longer includes bookmarks #3628

Merged
merged 1 commit into from
Aug 31, 2016
Merged

about:history no longer includes bookmarks #3628

merged 1 commit into from
Aug 31, 2016

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Aug 31, 2016 •
edited
Loading

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Ran git rebase -i to squash commits if needed.

Fixes #3627

Auditors: @alex, @charbelrami

Test Plan:

  • Bookmark a site
  • Visit about:history; verify bookmarked site (which was visited) shows up
  • Clear history
  • Search for that bookmark
  • It will no longer show up (after this patch)

@bsclifton
about:history no longer includes bookmarks
f27a139 
Fixes #3627

Auditors: @alex

Test Plan:
- Bookmark a site
- Visit about:history; verify bookmarked site (which was visited) shows up
- Clear history
- Search for that bookmark
- It will no longer show up (after this patch)
@bbondy bbondy added this to the 0.11.7dev milestone Aug 31, 2016
@bbondy
Copy link
Member

bbondy commented Aug 31, 2016

++ for 0.11.7

@bbondy bbondy merged commit 58ce528 into brave:master Aug 31, 2016
@luixxiul luixxiul mentioned this pull request Sep 1, 2016
Closed
@alexwykoff alexwykoff mentioned this pull request Sep 4, 2016
Closed
25 tasks
This was referenced Sep 5, 2016
Closed
Closed
Closed
Closed
Closed
@bsclifton bsclifton deleted the bookmarks-in-history-search branch September 16, 2016 03:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified
Projects
None yet
Milestone
0.12.0dev
Development

Successfully merging this pull request may close these issues.
4 participants
@bsclifton @bbondy @alexwykoff @srirambv