Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Dockable developer tools (F12) #3555

Closed
Sh1d0w opened this issue Aug 30, 2016 · 173 comments
Closed

Dockable developer tools (F12) #3555

Sh1d0w opened this issue Aug 30, 2016 · 173 comments
Labels
feature/developer-tools fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. parity Features which should be supported in Brave since they're supported in other major browsers. priority/P3 Major loss of function. product/developer-happiness product/user-happiness upstream wontfix

Comments

@Sh1d0w
Copy link

Sh1d0w commented Aug 30, 2016

Did you search for similar issues before submitting this one?

Yes

Describe the issue you encountered:

As a web developer which main browser currently is Brave I find using the developer tools (F12) frequently to inspect the webpage HTML and console output. Currently pressing F12 brings up the developer tools as a separate window. Chrome has option to attach the developer tools to the related window or even the tab you are inspecting. Brave does not have that option, making it pain switching between IDE and the browser window if you want to continiously inspect and observe the opened page.

Expected behavior:

Brave should allow attaching the developer tools (F12) in the relevant tab frame that was inspected.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All
  • Brave Version:
    All
  • Steps to reproduce:
    1. Open a webpage
    2. Press F12
    3. Observe the result
  • Screenshot if needed:

Chrome:

Brave:

- Any related issues:
@Sh1d0w
Copy link
Author

Sh1d0w commented Aug 30, 2016

From electron docs:

https://github.com/electron/electron/blob/master/docs/api/web-contents.md#contentsopendevtoolsoptions

contents.openDevTools([options])

    options Object (optional)
        mode String - Opens the devtools with specified dock state, can be right, bottom, undocked, detach. 
        Defaults to last used dock state. In undocked mode it's possible to dock back. In detach mode it's not.

For some reason it does not work if this option is changed in Brave here:

https://github.com/brave/browser-laptop/blob/master/js/components/frame.js#L450

This feature was introduced here:

electron/electron#5094

I wonder if you guys altered this behaviour in your electron fork?

cc @bbondy @bsclifton

@Sh1d0w Sh1d0w added this to the 0.11.7dev milestone Sep 1, 2016
@bbondy bbondy removed this from the 0.12.0dev milestone Sep 3, 2016
@bbondy
Copy link
Member

bbondy commented Sep 3, 2016

I'd love to have this too by the way.

Currently upstream hardcodes detach always for webviews. I'm not sure why but I've tried removing that condition and it didn't work. It would be awesome if you figure out why they did that and a fix though.

https://github.com/electron/electron/blob/46b257944113bba1c1258c485757bef421a5e110/atom/browser/api/atom_api_web_contents.cc#L944

@Sh1d0w
Copy link
Author

Sh1d0w commented Sep 7, 2016

@bbondy Here is the response from the issue I've rised with electron guys:

It is not possible with what we have now, in Chromium the webview is implemented as a 
browser plugin, and the docked devtools is implemented as native view, there is no 
way to mix them up.

Seems like this is not doable unfortunately :(

@Sh1d0w Sh1d0w closed this as completed Sep 7, 2016
@bbondy
Copy link
Member

bbondy commented Sep 7, 2016

It's do-able but they just don't plan to support it. Re-opening.

@bbondy bbondy reopened this Sep 7, 2016
@Sh1d0w Sh1d0w removed the wontfix label Sep 7, 2016
@DidibaDEV
Copy link

This is the only thing preventing me from switching to Brave for good.

@lednhatkhanh
Copy link

lednhatkhanh commented Nov 9, 2016

Please support this! Vivaldi has the same problem tho

@getsetbro
Copy link
Contributor

+1

@mrgoos
Copy link

mrgoos commented Dec 4, 2016

Hi,
Any news on that?

@rloechner
Copy link

+1

3 similar comments
@sahas-
Copy link

sahas- commented Jan 22, 2017

+1

@JoaoFOliveira
Copy link

+1

@NikolaiSzabados
Copy link

+1

@luixxiul luixxiul modified the milestones: 1.2.0, Backlog Feb 1, 2017
@thynquest
Copy link

That functionnality should be implemented a long time ago !
+1

@lekhnath
Copy link

lekhnath commented Feb 10, 2017

This feature is a must have.

@zackeryfretty
Copy link

+1

@erangeles
Copy link

Guys, if you want this browser to gain traction enabling developers ease of access is a key. Please please enable this feature.

@webhipster
Copy link

+1 Yup, just installed and uninstalling. Come on guys, you can do it! We believe in you!

@rjdp
Copy link

rjdp commented Aug 4, 2018

@mohsinbhaai read the comments above, also this no way to talk to people around here, nobody owes you anything, you've got to learn how to get around with people in open source projects :)

@remcovanessen
Copy link

glad I scrolled to the bottom as I was about to ditch Brave.... hoping it will be available soon!

@simon-hayden
Copy link

I was mostly chuffed with Brave after 24hrs. Not having dockable dev tools is a deal breaker, though, so am pleased this is (almost) here.

@ghost
Copy link

ghost commented Aug 31, 2018

Updated to the latest build of Brave. Hoping to see this included in the next version. As others have mentioned it would drastically make web developers more enthusiastic about Brave.

@sergiotapia
Copy link

On latest version is it still not up @HankHouser

@dwiyatci
Copy link

tumblr_inline_msw33st9h11qz4rgp

@bsclifton
Copy link
Member

@sergiotapia @HankHouser if you (or anyone else reading this) are willing to try an experimental build, you can download our latest release here:
https://github.com/brave/brave-browser/releases

brave-core is basically our developer channel now. We're slowly phasing out browser-laptop in favor of it 😄

@jonschr
Copy link

jonschr commented Sep 1, 2018

This is what I've been waiting for for like two years to switch over to Brave. Thanks! Looks fantastic.

@sergiotapia
Copy link

sergiotapia commented Sep 1, 2018

Downloading now @bsclifton

Alright, works awesome! Goodbye Chrome good riddance!!!

@WillKre
Copy link

WillKre commented Sep 4, 2018

@bsclifton writing to you live from my "Brave-Browser-Dev"...thank you! Took 10 seconds to get all my chrome preferences/settings, and looks great! Look forward to the full release, in the meantime... literally no reason for chrome anymore 🥇

@sergiotapia
Copy link

@bsclifton I don't mind using a browser on the edge. Will this update itself though as new releases come out? I do mind manually updating

@bsclifton
Copy link
Member

@sergiotapia great question - I confirmed with @RyanJarv that the builds do indeed auto-update 😄 👍

@davidapple
Copy link

Google Chrome have just updated their browser to a new design. Not to everyone's taste. Good time to switch to Brave but it's a shame the dev tools are not integrated into a stable release. It's amazing that there is a development version with dockable dev tools but when will be next stable release be?

@bsclifton
Copy link
Member

@davidapple per our release schedule, we're expecting to be stable and on the release channel by mid-October 😄

@forresthardin
Copy link

Good god I need this. Thanks Brave devs

@Mrs-Jaydot
Copy link

I'm completely new to Brave, loving it, but I need this too, can't wait! Thanks!!

@rjdp
Copy link

rjdp commented Oct 19, 2018

It's out, here you go https://brave.com/download .. chromium based now . .. Thanks a lot Brave team.

@thynquest
Copy link

On the chromium version I don' t see some features which existed previously.. like the "Show tab preview on hover" or "Clear the following data types when I close Brave".. is it normal ?
btw VERY NICE JOB brave team !

@cndouglas
Copy link

@thynquest Those features have not been re-implemented yet, but they are planned. See brave/brave-browser#275 and brave/brave-browser#492

@thynquest
Copy link

Ok thank you for the answer and again very nice job guys.. keep going !!

@arobbins
Copy link

arobbins commented Dec 8, 2018

Just wanted to say, now that this is fixed I'm officially moving from Chrome to Brave. Thanks Brave team for addressing!

@davidapple
Copy link

Brilliant, thanks. Time to delete Google Chrome.

@davidmoradi
Copy link

Download Brave Beta and you will have Dockable developer tools 🚀
https://brave.com/download-beta/

@Jacalz
Copy link
Contributor

Jacalz commented Dec 12, 2018

No need to download the beta when it’s already in stable and that has been the case for quite some time now 👌

@simon-hayden
Copy link

No need to download the beta when it’s already in stable and that has been the case for quite some time now 👌

@Jacalz, afraid not - developer tools currently only available as seperate window in stable.

@Jacalz
Copy link
Contributor

Jacalz commented Dec 12, 2018

Then you must be using the old muon based version or have some other issue, I have 0.57.18 and I can successfully open devtools attached to the window on both windows and MacOS 😬

@sjlehn
Copy link
Contributor

sjlehn commented Dec 12, 2018

@simon-hayden Make sure you actually have the current stable release (Version 0.57.18). Someone I was helping needed to re-download it because it didn't auto-update to the Chromium version.

@simon-hayden
Copy link

@sjlehn Thank you so much. Seems that I was in the same situation, with v0.25 not updating.

@Jacalz Thanks for alerting us to this! I imagine there are lots of people in the situation I have been, thinkin the old version would update to latest stable releases.

Also, for others finding this, the new version on macOS is "Brave Browser" (vs. previously "Brave"), so make sure you are launching the new application as well.

@Jacalz
Copy link
Contributor

Jacalz commented Dec 12, 2018

You are welcome and I believe that they are planning to update users of the muon version to he new version soon in the very near future. They have been waiting to have a rock solid update from the old version to the new 😅 @simon-hayden

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/developer-tools fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. parity Features which should be supported in Brave since they're supported in other major browsers. priority/P3 Major loss of function. product/developer-happiness product/user-happiness upstream wontfix
Projects
None yet
Development

No branches or pull requests