You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
The code currently has a special hard-coded case for settingKey === settings.ACTIVE_PASSWORD_MANAGER. Instead of having an if statement (which executes for every call) this could be reworked to have a default value determined in resolveValue(). The code is already lookup up static values using the format config.settings[key] but currently doesn't have a mechanism for handling more dynamic values, like the logic found in passwordManagerDefault().
For reference, see
browser-laptop/js/settings.js
Line 40 in af4e7df
The code currently has a special hard-coded case for
settingKey === settings.ACTIVE_PASSWORD_MANAGER
. Instead of having an if statement (which executes for every call) this could be reworked to have a default value determined in resolveValue(). The code is already lookup up static values using the formatconfig.settings[key]
but currently doesn't have a mechanism for handling more dynamic values, like the logic found in passwordManagerDefault().cc: @BrendanEich
The text was updated successfully, but these errors were encountered: