-
Notifications
You must be signed in to change notification settings - Fork 974
Upon install, URL bar always shows but doesn't match preferences #2301
Comments
Working on it. |
Reopened- I accidentally used closing keywords in another pull request |
I am not able reproduce this issue on 0.12.14 (If i understand the issue correctly). |
@gyandeeps this is a weird one- you have to have a fresh install of Brave. If you've already installed before, you'd have to clear your session folder (Windows - |
@gyandeeps this would be a pretty small scope bug; if you wanted to grab it, let me know 😄 |
@bsclifton after following the steps, what i saw was that the url bar was hiding when you had a webpage or something open. But url bar will not hide if ut was a new tab with no page open on that tab. Are you saying that it should still hide even if its a new tab without any rendered page on that tab? |
@bsclifton is this still an issue on Windows? "Always show the URL bar" is only enabled by default on Linux distros currently. @gyandeeps under Preferences -> General, we have an option "Always show the URL bar", which is disabled by default on Windows/Mac, but enabled for Linux (using Linux you'll always see the URL bar). The issue is: on a fresh start on Linux, the URL bar works as expected: it's visible (titleMode disabled). Title mode is hidden by default. But if you go to "Always show the URL bar" switch, it's disabled (opposite of what should be: enabled). So what's happening is that the feature works, but the switch button is not following. For a better view, this is what makes this option enabled by default on Linux distros: and this is the switch button (UI): It was an issue on Windows when @bsclifton reported but I can't repro now if it also happens on Linux |
ah.... i did remove all the settings... it was default off for me on windows.... i never changed that setting.... |
@cezaraugusto it's been an issue on all platforms actually; it just appears to be correct on Linux because of the default. Let me clear my session real quick and verify is this is still open |
@cezaraugusto looks like this issue has been fixed 😄 I tested multiple times on macOS and Windows with fresh session and was unable to reproduce. @gyandeeps the behavior (which is correct) that you should see is:
I looked back at the commit history and I believe I see where the issue was fixed 😄 I'll close this out thanks @cezaraugusto for retrying this and thank you @gyandeeps for taking the time to check it out also |
Did you search for similar issues before submitting this one?
yes
Describe the issue you encountered:
I tried out the RC today and noticed the URL bar was always showing. I went to about:preferences and then saw that the option for this was un-checked (which means it should NOT always be showing- it should auto-hide). I toggled the setting and from that point on, it worked as expected.
Expected behavior:
URL bar should auto-hide by default like it did before until the user changes the preference
Windows 7
0.10.4 RC3
The text was updated successfully, but these errors were encountered: