Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bravery panel, and per-site settings #1621

Closed
bradleyrichter opened this issue May 7, 2016 · 7 comments
Closed

Bravery panel, and per-site settings #1621

bradleyrichter opened this issue May 7, 2016 · 7 comments
Assignees
Labels
design A design change, especially one which needs input from the design team. feature/shields
Milestone

Comments

@bradleyrichter
Copy link
Contributor

bradleyrichter commented May 7, 2016

Overview:
As we complete the plumbing for maintaining per-site settings for various blocking and cookie attributes, users need a quick-access UI to control one or more of these attributes IF the need arrises for a particular site.

Some users may want to white-list sites for various reasons. This may include allowing one site to display normal ads and another to allow popups or 3rd party cookies if these settings are required for the purpose of browsing that site.

Occasionally a site may refuse to load because of our agressive blocking defaults.

Brave refers to these settings as "shields".

Plan
Quick access to per-site shields will be available through a panel that opens via the Bravery button in the navigation bar. This panel defaults to a collapsed view, and offers an easy-switch to bring all site shields UP or DOWN with one simple switch. This allows a user to quickly fix a site that may not be loading or doesn't appear as they expected. (a double-click on the Bravery button will serve as an advanced short-cut to the shields toggle switch for the current site.)

When the user needs more granular control over a particular setting, the advanced controls can be displayed. (the viewable state is remembered so they are visible again next time the panel is opened)

image

The display area shows a readout for the currently blocked ad count and tracker count for the current page, and provides access to more detail through a secondary popup list which is toggled by clicking on the number.

image

If shields are down, no information is displayed in this area:
image

Also shown in the above image, the bravery button changes it's color state to represent the state of Shields for that site.

Functionally, when shields are "down", all settings are reduced to thier minimum or off states until the shields are brought back "up". (also - this on/off state is site-wide and not just per page)

A decision to make related to this is whether these settings should simply be disabled (but viewable) while shields are down, or if they should be editable which would then create a new baseline for the site's shields settings as soon as one setting is changed from its off-state.

(the first iteration will use the disabled approach:)
image

Other V1 differences are listed and shown here:

  • the site icon will start by using the site favicon in it's largest available size, but 16x will be acceptable
  • time-saved will require more work and will come later
  • global shield setting overrides will not be available yet so the link to Prefs will be hidden

image

Community feedback is encouraged as always!

We know that many advanced users have requested per-element/per-site blocking control. We will not have this initially but will evaluate the necessity as we move forward.

Also, not shown in this UI are future exception lists that will be accessed through the settings/prefs panels.

@bradleyrichter bradleyrichter added this to the 0.10.0dev milestone May 7, 2016
@bradleyrichter bradleyrichter added documentation ✍ design A design change, especially one which needs input from the design team. labels May 7, 2016
@ghost
Copy link

ghost commented May 7, 2016

Looks nice, can't wait for it being implemented :)

@diracdeltas
Copy link
Member

Thanks brad! btw the spelling should be "phishing", not "fishing" in the mockups. 🐟

One thing to note is that we will eventually want to have per-ruleset controls for HTTPS Everywhere. not sure if those should go in the bravery panel, or if we should just have buttons for each browser "extension" separately.
screen shot 2016-05-08 at 11 57 49 pm

this may also be needed for NoScript eventually

@bradleyrichter
Copy link
Contributor Author

@diracdeltas Thanks for phinding that silly spelling error. I fhixed it! ; )

Regarding HTTPS, this would be a per-site exception list to connected sites within that site, correct?

@diracdeltas
Copy link
Member

@bradleyrichter that's right

@bbondy bbondy self-assigned this May 12, 2016
@bbondy bbondy closed this as completed in 4268d8d May 19, 2016
@bbondy bbondy changed the title Proposed design for Bravery panel, and per-site settings Bravery panel, and per-site settings May 20, 2016
@luixxiul
Copy link
Contributor

I have a question about "HTTP reroutes". Does this just display the number of reroutes or those of blocked, as an add-on like this https://addons.mozilla.org/en-GB/firefox/addon/clean-links/ does?

@diracdeltas
Copy link
Member

it displays the number of requests sent over-the-wire that were rewritten by HTTPS Everywhere

@bbondy
Copy link
Member

bbondy commented May 20, 2016

It's only wrt to http being converted to https.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
design A design change, especially one which needs input from the design team. feature/shields
Projects
None yet
Development

No branches or pull requests

4 participants