Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remind the user to generate a backup file #13425

Closed
mrose17 opened this issue Mar 12, 2018 · 7 comments
Closed

Remind the user to generate a backup file #13425

mrose17 opened this issue Mar 12, 2018 · 7 comments

Comments

@mrose17
Copy link
Member

mrose17 commented Mar 12, 2018

Test plan

See #13504

Original issue description

If the user has not created a backup file within 1 week of bootStamp, generate a notification reminding them to do so, with a button that brings up the dialog. The usual rules apply: "don't remind me", "remind me later", etc.

@jasonrsadler
Copy link
Contributor

@mrose17 @bradleyrichter
We have no way of knowing if an existing user has backed up their keys.
How should notifications be handled for existing users that update to new version?

Option 1:
This change should only work for new users (existing users that haven't backed up will not receive notification)

Option 2:
This change works for all users (which means existing users that have backed up will receive notification)

@srirambv
Copy link
Collaborator

@jasonrsadler mind updating the issue with verification steps.

@bsclifton
Copy link
Member

@srirambv plan updated 👍

@srirambv
Copy link
Collaborator

srirambv commented May 15, 2018

Verified on Windows x64

  • 0.22.712 e48c5ff
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.9

Verified with macOS 10.12.6 using

  • 0.22.712 e48c5ff
  • muon 6.0.9
  • libchromiumcontent 66.0.3359.139

@srirambv srirambv modified the milestones: 0.22.x Release 3 (Beta channel), 0.23.x (Developer Channel) May 15, 2018
@srirambv
Copy link
Collaborator

Moving based on feedback triage discussion and assigning to @mandar-brave

@bsclifton bsclifton reopened this May 15, 2018
@bsclifton bsclifton modified the milestones: 0.23.x (Developer Channel), 0.22.x Release 3 (Beta channel) May 15, 2018
@bsclifton
Copy link
Member

bsclifton commented May 15, 2018

Closing as the revert was reverted. Fix is contained in 0.22.712

@LaurenWags
Copy link
Member

LaurenWags commented May 16, 2018

Verified with macOS 10.12.6 using

  • 0.22.714 fa2fbca
  • muon 6.0.9
  • libchromiumcontent 66.0.3359.139

Verified on Windows x64

  • 0.22.714 fa2fbca
  • muon 6.0.9
  • libchromiumcontent 66.0.3359.139

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.