Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

1px margin causing gap between bookmarkButtonContainer & urlbarForm #13219

Closed
srirambv opened this issue Feb 21, 2018 · 1 comment
Closed

1px margin causing gap between bookmarkButtonContainer & urlbarForm #13219

srirambv opened this issue Feb 21, 2018 · 1 comment
Assignees
@srirambv
Labels
0.21.x issue first seen in 0.21.x bug feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.22.x (Release C...

Comments

@srirambv
Copy link
Collaborator

Description

1px margin causing gap between bookmarkButtonContainer & urlbarForm

Steps to Reproduce

  1. Build from fd80122
  2. Open a new tab and load any site
  3. Use system magnifier to zoom in on the URL bar to notice the gap (see screenshot)

Actual result:
image

Expected result:
Should not have the 1px margin causing the gap

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.21.10
V8 6.4.388.41
rev fd80122
Muon 5.0.2
OS Release 10.0.16299
Update Channel  
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 64.0.3282.140

Reproducible on current live release:
No

Additional Information
@srirambv srirambv added this to the 0.21.x (Beta Channel) milestone Feb 21, 2018
@srirambv srirambv self-assigned this Feb 21, 2018
@srirambv srirambv mentioned this issue Feb 21, 2018
Merged
10 tasks
@srirambv
Copy link
Collaborator Author

srirambv commented Mar 22, 2018 •
edited by kjozwiak
Loading

Verified on Windows x64

  • 0.22.6 e6ff4ea
  • libchromiumcontent: 65.0.3325.162
  • muon: 5.1.0

Verified on macOS 10.12.6 x64 using the following build:

  • 0.22.7 8bb7e77
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.1

Verified on Ubuntu 17.10 x64 using the following build:

  • 0.22.8 3ae27f2
  • libchromiumcontent: 65.0.3325.181
  • muon: 5.1.2

@kjozwiak kjozwiak mentioned this issue Mar 28, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@srirambv srirambv

Labels
0.21.x issue first seen in 0.21.x bug feature/URLbar QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.22.x (Release Channel)
Development

No branches or pull requests
3 participants
@kjozwiak @srirambv @LaurenWags