Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Error page text is too light #13162

Closed
cndouglas opened this issue Feb 16, 2018 · 3 comments
Closed

Error page text is too light #13162

cndouglas opened this issue Feb 16, 2018 · 3 comments
Assignees
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/about-pages polish Nice to have — usually related to front-end/visual tasks. priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/test-plan-specified release-notes/include wontfix

Comments

@cndouglas
Copy link

Description

IMO, some of the text on the error page is too light.

Steps to Reproduce

  1. Disconnect from the Internet.
  2. Open Brave and navigate to any URL.
  3. Look at the text that says "The Internet connection has been lost."

Actual result:
The text is too light to read clearly.

Expected result:
The text should be darker so that it's readable. Maybe it should be @chrometext (#555555)?

Reproduces how often:
Always.

Brave Version

Brave: 0.20.42
V8: 6.4.388.41
rev: 096c7cb
Muon: 4.8.2
OS Release: 17.4.0
Update Channel: Release
OS Architecture: x64
OS Platform: macOS
Node.js: 7.9.0
Brave Sync: v1.4.2
libchromiumcontent: 64.0.3282.140

Reproducible on current live release:
Yes, 0.20.42.

Additional Information

None.

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented Jun 14, 2018

13162
@bsclifton Issue still persists on 0.23.8

@bsclifton
Copy link
Member

@srirambv did you want to check this out? I verified the commit IS in 0.23.x, so I'm not sure if another style is overriding this. You might want to test using the tor/0.23.x branch

@srirambv
Copy link
Collaborator

I can check that again

@alexwykoff alexwykoff added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Jun 19, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Aug 24, 2018
@bsclifton bsclifton added addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. wontfix labels Aug 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. feature/about-pages polish Nice to have — usually related to front-end/visual tasks. priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). QA/test-plan-specified release-notes/include wontfix
Projects
None yet
Development

No branches or pull requests

6 participants