Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Updating UPDATE_HOST to point to brave.com cname #12304

Closed
jumde opened this issue Dec 16, 2017 · 4 comments · Fixed by #12305
Closed

Updating UPDATE_HOST to point to brave.com cname #12304

jumde opened this issue Dec 16, 2017 · 4 comments · Fixed by #12305
Labels
QA/no-qa-needed release-notes/include security
Milestone
0.20.x (Release C...

Comments

@jumde
Copy link
Contributor

jumde commented Dec 16, 2017 •
edited by bsclifton
Loading

Test plan

TBD

Original issue description

UPDATE_HOSTs are set to *.fastly.net. Update these entries to point to brave.com cnames
@diracdeltas diracdeltas mentioned this issue Dec 16, 2017
Closed
@jumde jumde mentioned this issue Dec 16, 2017
Merged
@diracdeltas diracdeltas added this to the 0.20.x (Beta Channel) milestone Dec 18, 2017
@bsclifton
Copy link
Member

@jumde can you provide a test plan for this issue?

@jumde
Copy link
Contributor Author

jumde commented Jan 23, 2018

From the PR:

Testing Notes: Geo logs for brave stats are captured using fastly. After this change download and update requests will go through brave domains which should go through fastly.net. Verify if stats is working correctly.

Also, verify if the  request for Brave updates are going through brave domains, instead of fastly.net.

cc: @diracdeltas

@cezaraugusto
Copy link
Contributor

I guess this should be in release-notes/exclude given this seems more like an infrastructure thing? not sure if this improves something for users

@cezaraugusto
Copy link
Contributor

thus no-qa-needed?

@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
QA/no-qa-needed release-notes/include security
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Issue 12304: Updating UPDATE_HOST to point to brave.com cname brave/browser-laptop
5 participants
@diracdeltas @jumde @cezaraugusto @bsclifton @srirambv