Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Context menu on bookmarksToolbar #12064

Closed
luixxiul opened this issue Nov 22, 2017 · 1 comment
Closed

Context menu on bookmarksToolbar #12064

luixxiul opened this issue Nov 22, 2017 · 1 comment
Assignees
@luixxiul
Labels
0.22.x issue first seen in 0.22.x bug feature/context-menu QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Nov 22, 2017 •
edited
Loading

Test plan

#12065 (comment)

Description

There is a gap between the icons and the label on the context menu items on bookmarksToolbar.

screenshot 2017-11-23 3 35 45

This is a regression bug caused by https://github.com/brave/browser-laptop/pull/11528/files#diff-d967b08f3e2eb972f1c3242327c1a4a1R292 of #11428.

Brave Version

about:brave info:

c5186d5

Reproducible on current live release:

No.

Additional Information
@luixxiul luixxiul self-assigned this Nov 22, 2017
@luixxiul luixxiul mentioned this issue Nov 22, 2017
Merged
8 tasks
@luixxiul luixxiul added this to the 0.22.x (Nightly Channel) milestone Nov 24, 2017
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
This was referenced Jun 11, 2018
Closed
Closed
Closed
@btlechowski
Copy link
Contributor

btlechowski commented Jun 14, 2018 •
edited by LaurenWags
Loading

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Windows 10 x64 using

  • 0.23.11 - 6565c06
  • Muon - 7.1.0
  • libchromiumcontent - 67.0.3396.87

Verified with macOS 10.12.6 using

  • 0.23.11 6565c06
  • Muon 7.1.0
  • libchromiumcontent 67.0.3396.87

This was referenced Jun 19, 2018
Closed
Closed
@srirambv srirambv mentioned this issue Jun 21, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
0.22.x issue first seen in 0.22.x bug feature/context-menu QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
5 participants
@bbondy @luixxiul @srirambv @LaurenWags @btlechowski