Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix the wrong BEM naming on paymentsTab.js #10912

Closed
luixxiul opened this issue Sep 12, 2017 · 1 comment
Closed

Fix the wrong BEM naming on paymentsTab.js #10912

luixxiul opened this issue Sep 12, 2017 · 1 comment
Assignees
@luixxiul
Labels
feature/about-pages QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Milestone
0.23.x (Release C...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Sep 12, 2017 •
edited
Loading

Test plan

#10913 (comment)

Describe the issue you encountered: Update paymentsTab.js to the modified BEM style (ref: https://github.com/brave/browser-laptop/blob/master/docs/style.md#defining-our-blocks-elements-and-modifiers).

I have refactored that file before the rule was created, so the styles are not organized well.

  • Brave Version (revision SHA): master branch

  • Any related issues:
@luixxiul luixxiul added feature/about-pages polish Nice to have — usually related to front-end/visual tasks. refactoring/aphrodite labels Sep 12, 2017
@luixxiul luixxiul mentioned this issue Sep 12, 2017
Merged
8 tasks
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Sep 13, 2017
@luixxiul luixxiul self-assigned this Sep 13, 2017
@ghost ghost removed the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Sep 26, 2017
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel), Backlog Oct 25, 2017
@luixxiul luixxiul removed the polish Nice to have — usually related to front-end/visual tasks. label Nov 18, 2017
@luixxiul luixxiul changed the title Update paymentsTab.js to our modified BEM style Fix the wrong BEM naming on paymentsTab.js Nov 18, 2017
@luixxiul luixxiul modified the milestones: Triage Backlog, 0.22.x (Nightly Channel) Nov 24, 2017
@bbondy bbondy modified the milestones: 0.22.x (Developer Channel), 0.23.x (Nightly Channel) Feb 25, 2018
This was referenced Jun 11, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator

srirambv commented Jun 14, 2018 •
edited by kjozwiak
Loading

Verified on Windows x64 using

  • 0.23.8 06c657b
  • muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on Ubuntu 17.10 x64

  • 0.23.8 06c657b
  • Muon 6.1.5
  • libchromiumcontent 66.0.3359.181

Verified on macOS 10.13.4 x64 using the following build:

  • 0.23.11 6565c06
  • muon: 7.1.0
  • libchromiumcontent: 67.0.3396.87

@srirambv srirambv mentioned this issue Jun 19, 2018
Closed
@srirambv srirambv mentioned this issue Jun 21, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luixxiul luixxiul

Labels
feature/about-pages QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified refactoring/aphrodite release-notes/exclude
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
5 participants
@bbondy @kjozwiak @luixxiul @srirambv @btlechowski