From e92fa090955c9cd6378b03a90e5eca6db7168506 Mon Sep 17 00:00:00 2001 From: "Brian R. Bondy" Date: Thu, 31 Aug 2017 19:08:26 -0400 Subject: [PATCH] Fix change of having last tab detached destroyed Auditors: @bridiver Fix #10436 This is covered by a test already but the bug is a very intermittent race condition. --- app/browser/tabs.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/browser/tabs.js b/app/browser/tabs.js index 5996d6a2c73..1f6598827db 100644 --- a/app/browser/tabs.js +++ b/app/browser/tabs.js @@ -499,7 +499,7 @@ const api = { // webcontents is still the embedder. const tabValue = getTabValue(tabId) const windowId = tabValue.get('windowId') - tab.once('will-attach', () => { + tab.once('did-attach', () => { appActions.tabStripEmpty(windowId) }) })