From b25da1a5520d3d0b505b36a0116f0b96675c8471 Mon Sep 17 00:00:00 2001 From: "Brian R. Bondy" Date: Mon, 29 Jan 2018 19:14:51 -0500 Subject: [PATCH] Temporarily disable autodiscardable tabs Fix #12916 --- app/browser/tabs.js | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/app/browser/tabs.js b/app/browser/tabs.js index a4bb4392a0d..2266e168c59 100644 --- a/app/browser/tabs.js +++ b/app/browser/tabs.js @@ -12,7 +12,7 @@ const tabState = require('../common/state/tabState') const {app, BrowserWindow, extensions, session, ipcMain} = require('electron') const {makeImmutable, makeJS} = require('../common/state/immutableUtil') const {getTargetAboutUrl, getSourceAboutUrl, isSourceAboutUrl, newFrameUrl, isTargetAboutUrl, isIntermediateAboutPage, isTargetMagnetUrl, getSourceMagnetUrl} = require('../../js/lib/appUrlUtil') -const {isURL, getUrlFromInput, toPDFJSLocation, getDefaultFaviconUrl, isHttpOrHttps, getLocationIfPDF} = require('../../js/lib/urlutil') +const {isURL, getUrlFromInput, toPDFJSLocation, getDefaultFaviconUrl, getLocationIfPDF} = require('../../js/lib/urlutil') const {isSessionPartition} = require('../../js/state/frameStateUtil') const {getOrigin} = require('../../js/lib/urlutil') const settingsStore = require('../../js/settings') @@ -113,11 +113,9 @@ const needsPartitionAssigned = (createProperties) => { } const isAutoDiscardable = (createProperties) => { - if (createProperties.pinned) { - return false - } - - return isHttpOrHttps(createProperties.url) + // Temporarily disabled due to bad handling for auto discarded tabs + // See https://github.com/brave/browser-laptop/issues/10673 + return false } const aboutTabs = {}