Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start operational patterns collection on Nightly #135

Merged
merged 1 commit into from
Sep 30, 2021

Conversation

LorenzoMinto
Copy link
Member

No description provided.

@LorenzoMinto LorenzoMinto merged commit a1f517c into main Sep 30, 2021
@kjozwiak kjozwiak deleted the operation-profile branch October 6, 2021 02:49
@kjozwiak
Copy link
Member

kjozwiak commented Oct 6, 2021

Verification PASSED on Win 10 x64 using the following build:

Brave | 1.32.46 Chromium: 94.0.4606.71 (Official Build) nightly (64-bit)
-- | --
Revision | 1d32b169326531e600d836bd395efc1b53d0f6ef-refs/branch-heads/4606@{#1256}
OS | Windows 11 Version 21H2 (Build 22000.194)

Locale & Channel Cases

  • ensured that OperationalPatternsCollectionStudy isn't being used/added into Variations under brave://version for the following locales:
    • Canada, Germany & France
Canada Example Germany Example France Example
Screenshot 2021-10-06 020745 disabledGermanyNightly disabledFranceNightly
  • ensured that OperationalPatternsCollectionStudy is being used/added into Variations under brave://version for USA

enabledUSANightly

  • verified that OperationalPatternsCollectionStudy isn't being listed under brave://version when using 1.31.71 Chromium: 94.0.4606.71 (BETA)
  • verified that OperationalPatternsCollectionStudy isn't being listed under brave://version when using 1.30.87 Chromium: 94.0.4606.71 (Release)
1.31.71 Chromium: 94.0.4606.71 (BETA) 1.30.87 Chromium: 94.0.4606.71 (Release)
betaDisabled releaseDisabled

P3A Disabled Case

  • launched 1.32.46 Chromium: 94.0.4606.71 using a new profile
  • opened brave://settings/?search=p3a and disabled Allow privacy-preserving product analytics (P3A)
  • restarted the browser and ensured that OperationalPatternsCollectionStudy:Disabled via brave://version

Note: Went through the above test ~30-40 times and ensured OperationalPatternsCollectionStudy was never Enabled

Example Example
disabledP3A disabledP3Aversion

OperationalPatternsCollectionStudy:Enabled Case

  • launched 1.32.46 Chromium: 94.0.4606.71 using a new profile
  • restarted the browser and checked brave://version
  • ensured that OperationalPatternsCollectionStudy -> Enabled
  • ensured that the federated section appears under brave://local-storage as per the following:
"federated": {
      "collection_id": "380FE0F4BE39B55F41E8B097C8649607",
      "collection_id_expiration": "13280571323551872",
      "last_checked_slot": -1
},

30 Days Case

  • launched 1.32.46 Chromium: 94.0.4606.71 using a new profile
  • restarted the browser and checked brave://version
  • ensured that OperationalPatternsCollectionStudy -> Enabled
  • ensured that the federated section appears under brave://local-storage as per the following:
"federated": {
      "collection_id": "380FE0F4BE39B55F41E8B097C8649607",
      "collection_id_expiration": "13280571323551872",
      "last_checked_slot": -1
},
  • moved the system date/time ahead by more than 30 days

  • checked brave://local-storage and ensured that the collection_id is different

  • "collection_id": "380FE0F4BE39B55F41E8B097C8649607" -> "collection_id": "09F6B648B215680E9E5A56375FF54502"

@kjozwiak
Copy link
Member

kjozwiak commented Oct 6, 2021

Just a heads up that I didn't check/verify the data that's being captured and sent to our server. That will need to be checked by @LorenzoMinto and team to make sure they're getting the correct data.

We'll also need to make sure that brave/brave-browser#17502 is fixed before we even thing of uplifting the above into Release:

  • ensure that data is being removed from brave://local-storage and other locations if the user disables P3A
  • ensure that data is being removed from server side when P3A has been disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants