This repository has been archived by the owner on May 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 441
Ref #3177: Add more regions for Ecosia. #3213
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
added
the
blocked
If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue
label
Jan 19, 2021
kylehickinson
approved these changes
Jan 19, 2021
Brandon-T
approved these changes
Jan 19, 2021
soner-yuksel
approved these changes
Jan 19, 2021
iccub
force-pushed
the
nobug/more_ecosia_regions
branch
from
January 20, 2021 00:06
646ac3c
to
62259d7
Compare
bsclifton
reviewed
Jan 20, 2021
bsclifton
suggested changes
Jan 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment left; I think one was put by accident, otherwise LGTM! 😄
iccub
force-pushed
the
nobug/more_ecosia_regions
branch
from
January 20, 2021 10:45
62259d7
to
490834a
Compare
@bsclifton thanks, removed 'BY', added it by mistake |
iccub
removed
the
blocked
If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue
label
Jan 20, 2021
bsclifton
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 😄👌
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Related desktop ticket brave/brave-browser#13511
This pull request references #3177
Submitter Checklist:
NSLocalizableString()
Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)
release-notes/(include|exclude)
bug
/enhancement