Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Update regions for search engine integrations #3221

Closed
kjozwiak opened this issue Jan 20, 2021 · 2 comments
Closed

Update regions for search engine integrations #3221

kjozwiak opened this issue Jan 20, 2021 · 2 comments

Comments

@kjozwiak
Copy link
Member

Copied from brave/brave-browser#13511 as per #3213 (comment).

## Description 
Follow up to https://github.com/brave/brave-browser/issues/13283
- [x] Add Ecosia for the following regions:
    - [x] Austria (AT)
    - [x] Denmark (DK)
    - [x] Luxembourg (LU)
    - [x] Norway (NO)
    - [x] Ireland (IE)
    - [x] Australia (AU)
    - [x] Spain (ES)
    - [x] Greece (GR)
    - [x] Italy (IT)
    - [x] Hungary (HU)
    - [x] Portugal (PT)
    - [x] Canada (CA)
    - [x] Finland (FI)
- [ ] Update wiki (https://github.com/brave/internal/wiki/Search-engine-integrations)

## Test plan
### Verify changes in the `Default search engines` list
1. Set locale to one of the supported locales (see list above)- for example CA
2. New profile
3. Launch Brave, go through onboarding to search engine step. Verify:
    - _Ecosia_ shows in list (should be towards the end)
4. Open brave://settings/searchEngines in a new tab. Verify:
    - _Ecosia_ shows in list (should be towards the end)

### Verify the Ecosia referral IDs used are correct
1. Do a search (on Android/Desktop) using Ecosia
2. Verify `tt=` part of URL fragment matches referral code shown in https://github.com/brave/internal/wiki/Search-engine-integrations
@kjozwiak
Copy link
Member Author

Closing as this was added/implemented via #3213.

@kjozwiak
Copy link
Member Author

kjozwiak commented Jan 21, 2021

Verification PASSED on iPad Mini 4 running iOS 13.7. using 1.22.2 (21.1.20.17):

New Installs

Went through the following for each region:

Supported Regions - Austria
Austria Austria (Standard) Austria (Private) Austria (Selected/Quick Search)
IMG_0367 IMG_0368 IMG_0369 IMG_0370
Supported Regions - Denmark
Denmark Denmark (Standard) Denmark (Private) Denmark (Selected/Quick Search)
IMG_0373 IMG_0374 IMG_0375 IMG_0377
Supported Regions - Luxembourg
Luxembourg Luxembourg (Standard) Luxembourg (Private) Luxembourg (Selected/Quick Search)
IMG_0378 IMG_0381 IMG_0380 IMG_0379
Supported Regions - Norway
Norway Norway (Standard) Norway (Private) Norway (Selected/Quick Search)
IMG_0382 IMG_0384 IMG_0385 IMG_0383
Supported Regions - Australia

Note: ensured that DDG was the default SE

Australia Australia (Standard) Australia (Private) Australia (Selected/Quick Search)
IMG_0386 IMG_0387 IMG_0388 IMG_0389
Supported Regions - Spain
Spain Spain (Standard) Spain (Private) Spain (Selected/Quick Search)
IMG_0390 IMG_0391 IMG_0392 IMG_0393
Supported Regions - Greece
Greece Greece (Standard) Greece (Private) Greece (Selected/Quick Search)
IMG_0394 IMG_0395 IMG_0396 IMG_0397
Supported Regions - Italy
Italy Italy (Standard) Italy (Private) Italy (Selected/Quick Search)
IMG_0398 IMG_0399 IMG_0400 IMG_0403
Supported Regions - Hungary
Hungary Hungary (Standard) Hungary (Private) Hungary (Selected/Quick Search)
IMG_0404 IMG_0405 IMG_0406 IMG_0407
Supported Regions - Portugal
Portugal Portugal (Standard) Portugal (Private) Portugal (Selected/Quick Search)
IMG_0408 IMG_0409 IMG_0410 IMG_0411
Supported Regions - Finland
Finland Finland (Standard) Finland (Private) Finland (Selected/Quick Search)
IMG_0424 IMG_0427 IMG_0426 IMG_0425

Upgrades

Case 1 - Canada
  • downloaded and changed the default SE to Yahoo for both Standard Tabs & Private Tabs
  • updated to 1.22.2 (21.2.21.17) via TF
  • ensured that Yahoo was still the default search engine for both Standard Tabs & Private Tabs
  • ensured that Ecosia is being displayed under the Quick-Search Engines list
  • ensured that Ecoisa is being added into the Standard Tab SE list
  • ensured that Ecosia is being added into the Private Tab SE list
Canada (Selected Default/Quick Search) Canada (Standard & Private Tab)
IMG_0420 IMG_0421
Case 2 - Ireland
  • downloaded 1.22.1 (20.12.10.23) and left the DDG (default for Ireland) as default SE for both Standard Tabs & Private Tabs
  • updated to 1.22.2 (21.2.21.17) via TF
  • ensured that DDG was still the default search engine for both Standard Tabs & Private Tabs
  • ensured that Ecosia is being displayed under the Quick-Search Engines list
  • ensured that Ecoisa is being added into the Standard Tab SE list
  • ensured that Ecosia is being added into the Private Tab SE list
Ireland (Selected Default/Quick Search) Ireland (Standard & Private Tab)
IMG_0422 IMG_0423
Case 3 - Finland
  • downloaded 1.22.1 (20.12.10.23) and set Startpage as default SE for Standard Tabs & DDG for Private Tabs
  • disabled quick search on all of the other SE
  • updated to 1.22.2 (21.2.21.17) via TF
  • ensured that DDG was still the default search engine for both Standard Tabs & Private Tabs
  • ensured that Ecosia is being displayed under the Quick-Search Engines list
  • ensured that Ecoisa is being added into the Standard Tab SE list
  • ensured that Ecosia is being added into the Private Tab SE list
Finland(Selected Default/Quick Search) Finland (Standard) Finland (Private Tab)
IMG_0429 IMG_0430 IMG_0431

Verification passed on iPhone 7+ with iOS 14.3 running 1.22.2(21.1.20.17)
Clean Install

Austria
Onboarding Default SE list Quick Search Engine list
image image image
Denmark - No translations
Onboarding Default SE list Quick Search Engine list
image image image
Norway
Onboarding Default SE list Quick Search Engine list
image image image
Spain
Onboarding Default SE list Quick Search Engine list
image image image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants