Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix Brave Ads state-level targeting crash #2692

Closed
tmancey opened this issue Jul 2, 2020 · 1 comment
Closed

Fix Brave Ads state-level targeting crash #2692

tmancey opened this issue Jul 2, 2020 · 1 comment
Assignees
@tmancey
Labels
crash Epic: Ads priority/P3 The next thing for us to work on. QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.21

Comments

@tmancey
Copy link
Collaborator

tmancey commented Jul 2, 2020

Description:

Fix Brave Ads state-level targeting crash

Steps to Reproduce

  1. Disable state-level targeting in Ads settings (US Only)

Actual result:
App crashes

Expected result:
App should not crash

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily reproduced

Brave Version:
1.20.x

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information
@tmancey tmancey self-assigned this Jul 2, 2020
@tmancey tmancey added this to the 1.20 milestone Jul 2, 2020
@kylehickinson kylehickinson modified the milestones: 1.20, 1.21 Jul 7, 2020
@tmancey tmancey mentioned this issue Jul 7, 2020
Merged
7 tasks
@srirambv
Copy link
Contributor

srirambv commented Oct 8, 2020

Verification passed on the following devices running 1.21(20.10.08.09)

  • Verified disabling state-level target doesn't cause crash
iPhone XR (iOS 13.5) iPhone 7+ (iOS 14.0.1) iPad Pro (iOS 12.4.1)
image image image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@tmancey tmancey

Labels
crash Epic: Ads priority/P3 The next thing for us to work on. QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.21
Development

No branches or pull requests
3 participants
@kylehickinson @tmancey @srirambv