From 8103f79d5941ca17db7cfaf57e15d66af7547293 Mon Sep 17 00:00:00 2001 From: Nuo Xu Date: Fri, 24 Nov 2023 07:25:00 -0500 Subject: [PATCH] code review suggestion --- .../BraveWallet/Crypto/Onboarding/BackupWalletView.swift | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/Sources/BraveWallet/Crypto/Onboarding/BackupWalletView.swift b/Sources/BraveWallet/Crypto/Onboarding/BackupWalletView.swift index 3eb0e1da1ae..7969d456385 100644 --- a/Sources/BraveWallet/Crypto/Onboarding/BackupWalletView.swift +++ b/Sources/BraveWallet/Crypto/Onboarding/BackupWalletView.swift @@ -35,8 +35,11 @@ struct BackupWalletView: View { return } - // password filed resign first responder in case ScrollView gets changed - // which could effect the next step. Details see #8445 + // Dismiss keyboard for password field before leaving this view #8445. + // Without dismissal, it's possible the scroll view in the detail view + // has incorrect frame (sitting above the area the keyboard used to be) + // which can show the scroll view contents out of the scroll bounds + // but will block tap interactions. resignFirstResponder() keyringStore.recoveryPhrase(password: password) { words in