Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift 1.29.x - inconsistent ui string casing in menu #9712

Merged
merged 1 commit into from
Aug 11, 2021
Merged

Uplift 1.29.x - inconsistent ui string casing in menu #9712

merged 1 commit into from
Aug 11, 2021

Conversation

nullhook
Copy link
Contributor

@nullhook nullhook commented Aug 10, 2021 •
edited by petemill
Loading

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Initial PR: #9636

Resolves brave/brave-browser#17308 and
Resolves brave/brave-browser#17309
This should fix casing on all os.

@nullhook
Merge pull request #9636 from brave/bug/menu-item-casing
b114c11 
Fixed ui string casing for menu items
@nullhook nullhook requested a review from a team August 10, 2021 19:38
@nullhook nullhook added this to the 1.29.x - Beta milestone Aug 10, 2021
kjozwiak
kjozwiak approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.29.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #9636 (comment). Quick note: brave/brave-browser#17377 was created a follow up to address the New Private window --> New private window issue.

@kjozwiak kjozwiak merged commit 3f348e1 into 1.29.x Aug 11, 2021
@kjozwiak kjozwiak deleted the bug/menu-item-casing-1.29.x branch August 11, 2021 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@nullhook nullhook

Labels
None yet
Projects
None yet
Milestone
1.29.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@nullhook @kjozwiak