Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove PermissionLifetime feature from brave://flags. #9448

Merged
merged 2 commits into from
Jul 16, 2021
Merged

Remove PermissionLifetime feature from brave://flags. #9448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ee27a0
Remove PermissionLifetime feature from brave://flags.
goodov Jul 15, 2021
0a9e44f
Drop the header.
goodov Jul 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions chromium_src/chrome/browser/about_flags.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
#include "brave/components/speedreader/buildflags.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/browser/profiles/profile_manager.h"
#include "components/permissions/features.h"
#include "components/prefs/pref_service.h"
#include "net/base/features.h"

Expand Down Expand Up @@ -191,10 +190,6 @@ using ntp_background_images::features::kBraveNTPSuperReferralWallpaper;
flag_descriptions::kBraveEphemeralStorageKeepAliveName, \
flag_descriptions::kBraveEphemeralStorageKeepAliveDescription, kOsAll, \
FEATURE_VALUE_TYPE(net::features::kBraveEphemeralStorageKeepAlive)}, \
{"brave-permission-lifetime", \
flag_descriptions::kBravePermissionLifetimeName, \
flag_descriptions::kBravePermissionLifetimeDescription, kOsAll, \
FEATURE_VALUE_TYPE(permissions::features::kPermissionLifetime)}, \
goodov marked this conversation as resolved.
Show resolved Hide resolved
{"brave-rewards-verbose-logging", \
flag_descriptions::kBraveRewardsVerboseLoggingName, \
flag_descriptions::kBraveRewardsVerboseLoggingDescription, \
Expand Down
4 changes: 0 additions & 4 deletions chromium_src/chrome/browser/flag_descriptions.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,6 @@ const char kBraveEphemeralStorageKeepAliveName[] =
const char kBraveEphemeralStorageKeepAliveDescription[] =
"Keep ephemeral storage partitions alive for a specified time after all "
"tabs for that origin are closed";
const char kBravePermissionLifetimeName[] = "Permission Lifetime";
const char kBravePermissionLifetimeDescription[] =
"Enables the option to choose a time period after which a permission will "
"be automatically revoked";

#if BUILDFLAG(ENABLE_GEMINI_WALLET)
const char kBraveRewardsGeminiName[] = "Enable Gemini for Brave Rewards";
Expand Down
2 changes: 0 additions & 2 deletions chromium_src/chrome/browser/flag_descriptions.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,6 @@ extern const char kBraveEphemeralStorageName[];
extern const char kBraveEphemeralStorageDescription[];
extern const char kBraveEphemeralStorageKeepAliveName[];
extern const char kBraveEphemeralStorageKeepAliveDescription[];
extern const char kBravePermissionLifetimeName[];
extern const char kBravePermissionLifetimeDescription[];
} // namespace flag_descriptions

#endif // BRAVE_CHROMIUM_SRC_CHROME_BROWSER_FLAG_DESCRIPTIONS_H_