From 4ee27a0e2cd32cdaf8ef77e933e6d295939b1677 Mon Sep 17 00:00:00 2001 From: Aleksey Khoroshilov Date: Thu, 15 Jul 2021 20:54:36 +0700 Subject: [PATCH 1/2] Remove PermissionLifetime feature from brave://flags. --- chromium_src/chrome/browser/about_flags.cc | 4 ---- chromium_src/chrome/browser/flag_descriptions.cc | 4 ---- chromium_src/chrome/browser/flag_descriptions.h | 2 -- 3 files changed, 10 deletions(-) diff --git a/chromium_src/chrome/browser/about_flags.cc b/chromium_src/chrome/browser/about_flags.cc index 503a4f4fccf8..75c28c669cc1 100644 --- a/chromium_src/chrome/browser/about_flags.cc +++ b/chromium_src/chrome/browser/about_flags.cc @@ -191,10 +191,6 @@ using ntp_background_images::features::kBraveNTPSuperReferralWallpaper; flag_descriptions::kBraveEphemeralStorageKeepAliveName, \ flag_descriptions::kBraveEphemeralStorageKeepAliveDescription, kOsAll, \ FEATURE_VALUE_TYPE(net::features::kBraveEphemeralStorageKeepAlive)}, \ - {"brave-permission-lifetime", \ - flag_descriptions::kBravePermissionLifetimeName, \ - flag_descriptions::kBravePermissionLifetimeDescription, kOsAll, \ - FEATURE_VALUE_TYPE(permissions::features::kPermissionLifetime)}, \ {"brave-rewards-verbose-logging", \ flag_descriptions::kBraveRewardsVerboseLoggingName, \ flag_descriptions::kBraveRewardsVerboseLoggingDescription, \ diff --git a/chromium_src/chrome/browser/flag_descriptions.cc b/chromium_src/chrome/browser/flag_descriptions.cc index 80d7a7fb090c..447637017dfe 100644 --- a/chromium_src/chrome/browser/flag_descriptions.cc +++ b/chromium_src/chrome/browser/flag_descriptions.cc @@ -99,10 +99,6 @@ const char kBraveEphemeralStorageKeepAliveName[] = const char kBraveEphemeralStorageKeepAliveDescription[] = "Keep ephemeral storage partitions alive for a specified time after all " "tabs for that origin are closed"; -const char kBravePermissionLifetimeName[] = "Permission Lifetime"; -const char kBravePermissionLifetimeDescription[] = - "Enables the option to choose a time period after which a permission will " - "be automatically revoked"; #if BUILDFLAG(ENABLE_GEMINI_WALLET) const char kBraveRewardsGeminiName[] = "Enable Gemini for Brave Rewards"; diff --git a/chromium_src/chrome/browser/flag_descriptions.h b/chromium_src/chrome/browser/flag_descriptions.h index b326ef371513..e7cba1b427a9 100644 --- a/chromium_src/chrome/browser/flag_descriptions.h +++ b/chromium_src/chrome/browser/flag_descriptions.h @@ -61,8 +61,6 @@ extern const char kBraveEphemeralStorageName[]; extern const char kBraveEphemeralStorageDescription[]; extern const char kBraveEphemeralStorageKeepAliveName[]; extern const char kBraveEphemeralStorageKeepAliveDescription[]; -extern const char kBravePermissionLifetimeName[]; -extern const char kBravePermissionLifetimeDescription[]; } // namespace flag_descriptions #endif // BRAVE_CHROMIUM_SRC_CHROME_BROWSER_FLAG_DESCRIPTIONS_H_ From 0a9e44fd21f3d3b6a137d2f0f03a03c0256336f5 Mon Sep 17 00:00:00 2001 From: Aleksey Khoroshilov Date: Fri, 16 Jul 2021 02:17:25 +0700 Subject: [PATCH 2/2] Drop the header. --- chromium_src/chrome/browser/about_flags.cc | 1 - 1 file changed, 1 deletion(-) diff --git a/chromium_src/chrome/browser/about_flags.cc b/chromium_src/chrome/browser/about_flags.cc index 75c28c669cc1..e69c181bd88e 100644 --- a/chromium_src/chrome/browser/about_flags.cc +++ b/chromium_src/chrome/browser/about_flags.cc @@ -21,7 +21,6 @@ #include "brave/components/speedreader/buildflags.h" #include "chrome/browser/profiles/profile.h" #include "chrome/browser/profiles/profile_manager.h" -#include "components/permissions/features.h" #include "components/prefs/pref_service.h" #include "net/base/features.h"