Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable HTTP UA farbling [1.23.x] #8590

Closed
wants to merge 1 commit into from

Conversation

pilgrim-brave
Copy link
Contributor

@pilgrim-brave pilgrim-brave commented Apr 21, 2021

Resolves brave/brave-browser#15039

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@pilgrim-brave pilgrim-brave changed the title Disable HTTP UA farbling Disable HTTP UA farbling [1.23.x] Apr 21, 2021
@kjozwiak kjozwiak requested a review from a team April 21, 2021 15:55
@kjozwiak kjozwiak added this to the 1.23.x - Release #2 milestone Apr 21, 2021
@kjozwiak
Copy link
Member

test-browser failed on macOS as per https://ci.brave.com/job/pr-brave-browser-mpilgrim_1.23.x_disable_ua_farbling-macos/1/execution/node/242/log/ & https://ci.brave.com/job/pr-brave-browser-mpilgrim_1.23.x_disable_ua_farbling-macos/1/execution/node/245/log/. However, these are known issues and unrelated to this specific PR.

13:25:10  5 tests crashed:
13:25:10      BraveStatsUpdaterBrowserTest.StatsUpdaterMigration (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:275)
13:25:10      BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:154)
13:25:10      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:229)
13:25:10      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:327)
13:25:10      BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:191)

post-init failed due to audit-deps warnings as per https://ci.brave.com/job/pr-brave-browser-mpilgrim_1.23.x_disable_ua_farbling-post-init/1/execution/node/145/log/. However, this is a known warning/failure and unrelated to this specific PR.

test-browser failed on Linux as per https://ci.brave.com/job/pr-brave-browser-mpilgrim_1.23.x_disable_ua_farbling-linux/1/execution/node/244/log/ & https://ci.brave.com/job/pr-brave-browser-mpilgrim_1.23.x_disable_ua_farbling-linux/1/execution/node/247/log/. However, these are known issues and unrelated to this specific PR.

11:42:44  5 tests crashed:
11:42:44      BraveStatsUpdaterBrowserTest.StatsUpdaterMigration (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:275)
11:42:44      BraveStatsUpdaterBrowserTest.StatsUpdaterSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:154)
11:42:44      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithDefaultReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:229)
11:42:44      BraveStatsUpdaterBrowserTest.StatsUpdaterStartupPingWithReferralCode (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:327)
11:42:44      BraveStatsUpdaterBrowserTest.StatsUpdaterThresholdSetsFirstCheckPreference (../../brave/browser/brave_stats/brave_stats_updater_browsertest.cc:191)

@kjozwiak
Copy link
Member

Closing in favour of #8600 as per earlier discussions.

@kjozwiak kjozwiak closed this Apr 22, 2021
@kjozwiak kjozwiak removed the request for review from a team April 22, 2021 02:00
@kjozwiak kjozwiak removed this from the 1.23.x - Release #2 milestone Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants