Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet panel is now cleared when wallet is restored #777

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Wallet panel is now cleared when wallet is restored #777

merged 1 commit into from
Nov 2, 2018

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Oct 31, 2018 •
edited by NejcZdovc
Loading

Fixes brave/brave-browser#1559

Ledger implementation: brave-intl/bat-native-ledger#166

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. Start Brave.
  2. Perform Rewards activities to fill a wallet summary (accept grant, page tip, etc)
  3. Restore wallet with a previously saved wallet
  4. Verify that wallet summary in Rewards page and Rewards panel is cleared.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@jasonrsadler jasonrsadler self-assigned this Oct 31, 2018
@jasonrsadler jasonrsadler mentioned this pull request Oct 31, 2018
Merged
@jasonrsadler jasonrsadler changed the title Fixes brave/brave-browser#1559 WIP - Fixes brave/brave-browser#1559 Nov 1, 2018
@NejcZdovc NejcZdovc changed the title WIP - Fixes brave/brave-browser#1559 Reset reports after recovery Nov 2, 2018
@NejcZdovc
Copy link
Contributor

@jasonrsadler please squash commits and add test plan

@jasonrsadler jasonrsadler changed the title Reset reports after recovery Wallet panel is now cleared when wallet is restored Nov 2, 2018
@NejcZdovc NejcZdovc mentioned this pull request Nov 2, 2018
Closed
Fixes brave/brave-browser#1559
0d9cb6d 
Updated ledger depenedency
@NejcZdovc NejcZdovc merged commit 81b7b20 into brave:master Nov 2, 2018
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Nov 2, 2018 •
edited
Loading

master (0.59.x) 81b7b20
0.58.x b21d6b1

@jasonrsadler jasonrsadler deleted the clear-reports-core branch November 2, 2018 17:33
NejcZdovc added a commit that referenced this pull request Nov 7, 2018
@NejcZdovc
Merge pull request #777 from jasonrsadler/clear-reports-core
b21d6b1 
Wallet panel is now cleared when wallet is restored
@bbondy bbondy added this to the 0.58.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NejcZdovc NejcZdovc NejcZdovc approved these changes

Assignees

@jasonrsadler jasonrsadler

Labels
feature/rewards
Projects
None yet
Milestone
0.58.x - Release
Development

Successfully merging this pull request may close these issues.

summary table should be cleared when another wallet is restored
3 participants
@jasonrsadler @NejcZdovc @bbondy