Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Ecosia as an alternative search in several regions (uplift to 1.20.x) #7656

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Add Ecosia as an alternative search in several regions (uplift to 1.20.x) #7656

merged 1 commit into from
Jan 22, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jan 19, 2021 •
edited by kjozwiak
Loading

Uplift of #7622
Fixes brave/brave-browser#13511

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner January 19, 2021 20:51
@brave-builds brave-builds requested a review from a team January 19, 2021 20:51
@brave-builds brave-builds self-assigned this Jan 19, 2021
@brave-builds brave-builds added this to the 1.20.x - Beta milestone Jan 19, 2021
@bsclifton bsclifton removed the request for review from a team January 19, 2021 20:57
kjozwiak
kjozwiak approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.20.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #7622 (comment).

@kjozwiak kjozwiak merged commit 44b6577 into 1.20.x Jan 22, 2021
@kjozwiak kjozwiak deleted the pr7622_bsc-ecosia-addl-regions_1.20.x branch January 22, 2021 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.20.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@brave-builds @kjozwiak @brave-browser-releases