Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature flags and epsilon greedy bandit for Brave Ads #7484

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Add feature flags and epsilon greedy bandit for Brave Ads #7484

merged 1 commit into from
Jan 5, 2021

Conversation

moritzhaller
Copy link
Contributor

@moritzhaller moritzhaller commented Dec 19, 2020 •
edited
Loading

Resolves brave/brave-browser#12595

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

tested as part of #7533

@moritzhaller moritzhaller changed the title Add feature flags and parameters for text classification and purchase… Add feature flags and epsilon greedy bandit for Brave Ads Dec 19, 2020
@moritzhaller moritzhaller self-assigned this Dec 19, 2020
@moritzhaller moritzhaller force-pushed the issues/12595 branch 3 times, most recently from abb567d to f13c765 Compare December 21, 2020 16:31
@moritzhaller moritzhaller marked this pull request as ready for review December 21, 2020 16:32
@moritzhaller moritzhaller force-pushed the issues/12595 branch 4 times, most recently from d5209c6 to a64ee37 Compare December 28, 2020 09:24
@moritzhaller moritzhaller force-pushed the issues/12595 branch 4 times, most recently from 086956e to 6012ec1 Compare January 5, 2021 12:04
tmancey
tmancey requested changes Jan 5, 2021
View reviewed changes
...bat/ads/internal/ad_targeting/data_types/behavioral/bandits/epsilon_greedy_bandit_arm_info.h Outdated Show resolved Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/ad_targeting/ad_targeting.cc Outdated Show resolved Hide resolved
.../internal/ad_serving/ad_targeting/models/behavioral/purchase_intent/purchase_intent_model.cc Outdated Show resolved Hide resolved
...at/ads/internal/ad_targeting/data_types/behavioral/bandits/epsilon_greedy_bandit_arm_info.cc Outdated Show resolved Hide resolved
...bat/ads/internal/ad_targeting/data_types/behavioral/bandits/epsilon_greedy_bandit_arm_info.h Outdated Show resolved Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/ads_impl.cc Show resolved Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/ads_impl.h Outdated Show resolved Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/features/features.cc Outdated Show resolved Hide resolved
...-native-ads/src/bat/ads/internal/features/text_classification/text_classification_features.h Outdated Show resolved Hide resolved
...s/src/bat/ads/internal/features/text_classification/text_classification_features_unittest.cc Outdated Show resolved Hide resolved
@tmancey tmancey self-requested a review January 5, 2021 13:52
@moritzhaller moritzhaller force-pushed the issues/12595 branch 2 times, most recently from 3a92c0c to 8a39bc6 Compare January 5, 2021 17:54
tmancey
tmancey approved these changes Jan 5, 2021
View reviewed changes
Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

@moritzhaller
Copy link
Contributor Author

unrelated test failing on iOS

@moritzhaller moritzhaller merged commit 7d58e33 into master Jan 5, 2021
@moritzhaller moritzhaller deleted the issues/12595 branch January 5, 2021 21:46
@kjozwiak kjozwiak mentioned this pull request Jan 6, 2021
Closed
@moritzhaller moritzhaller added this to the 1.20.x - Nightly milestone Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmancey tmancey tmancey approved these changes

Assignees

@moritzhaller moritzhaller

Labels
feature/ads
Projects
None yet
Milestone
1.20.x - Release
Development

Successfully merging this pull request may close these issues.

Add epsilon greedy bandit classifier for Brave Ads matching
2 participants
@moritzhaller @tmancey