-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output dir of signing on mac changed. #7399
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkarolin
added
CI/skip-android
Do not run CI builds for Android
CI/skip-linux
CI/skip-ios
Do not run CI builds for iOS
labels
Dec 10, 2020
Chromium change: https://chromium.googlesource.com/chromium/src.git/+/09ab75a5507efc8465c6d1e467fae95b78294ed3 commit 09ab75a5507efc8465c6d1e467fae95b78294ed3 Author: Avi Drissman <avi@chromium.org> Date: Fri Oct 30 15:59:39 2020 +0000 Mac packaging: make distributions that can share app bundles do so Bug: 1142508
mkarolin
force-pushed
the
maxk-fix-mac-signing
branch
from
December 10, 2020 00:39
dcad47e
to
7c85832
Compare
mkarolin
changed the title
WIP: Output dir of signing on mac changed.
Output dir of signing on mac changed.
Dec 10, 2020
|
simonhong
approved these changes
Dec 10, 2020
mihaiplesa
approved these changes
Dec 10, 2020
mkarolin
pushed a commit
that referenced
this pull request
Jan 4, 2021
Output dir of signing on mac changed.
mkarolin
pushed a commit
that referenced
this pull request
Jan 8, 2021
Output dir of signing on mac changed.
23 tasks
mkarolin
pushed a commit
that referenced
this pull request
Jan 12, 2021
Output dir of signing on mac changed.
mkarolin
pushed a commit
that referenced
this pull request
Jan 12, 2021
Output dir of signing on mac changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes brave/brave-browser#13130
Chromium change:
https://chromium.googlesource.com/chromium/src.git/+/09ab75a5507efc8465c6d1e467fae95b78294ed3
commit 09ab75a5507efc8465c6d1e467fae95b78294ed3
Author: Avi Drissman avi@chromium.org
Date: Fri Oct 30 15:59:39 2020 +0000
Resolves
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed).Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on.
Test Plan: