Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output dir of signing on mac changed. #7399

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Dec 10, 2020

Fixes brave/brave-browser#13130

Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/09ab75a5507efc8465c6d1e467fae95b78294ed3

commit 09ab75a5507efc8465c6d1e467fae95b78294ed3
Author: Avi Drissman avi@chromium.org
Date: Fri Oct 30 15:59:39 2020 +0000

Mac packaging: make distributions that can share app bundles do so

Bug: 1142508

Resolves

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin added CI/skip-android Do not run CI builds for Android CI/skip-linux CI/skip-ios Do not run CI builds for iOS labels Dec 10, 2020
@mkarolin mkarolin self-assigned this Dec 10, 2020
Chromium change:

https://chromium.googlesource.com/chromium/src.git/+/09ab75a5507efc8465c6d1e467fae95b78294ed3

commit 09ab75a5507efc8465c6d1e467fae95b78294ed3
Author: Avi Drissman <avi@chromium.org>
Date:   Fri Oct 30 15:59:39 2020 +0000

    Mac packaging: make distributions that can share app bundles do so

    Bug: 1142508
@mkarolin mkarolin changed the title WIP: Output dir of signing on mac changed. Output dir of signing on mac changed. Dec 10, 2020
@mkarolin
Copy link
Collaborator Author

dist succeeded for Nightly and Release.

@mihaiplesa mihaiplesa merged commit e79d1bf into master Dec 10, 2020
@mihaiplesa mihaiplesa deleted the maxk-fix-mac-signing branch December 10, 2020 06:46
@mkarolin mkarolin added this to the 1.20.x - Nightly milestone Dec 10, 2020
mkarolin pushed a commit that referenced this pull request Jan 4, 2021
Output dir of signing on mac changed.
mkarolin pushed a commit that referenced this pull request Jan 8, 2021
Output dir of signing on mac changed.
mkarolin pushed a commit that referenced this pull request Jan 12, 2021
Output dir of signing on mac changed.
mkarolin pushed a commit that referenced this pull request Jan 12, 2021
Output dir of signing on mac changed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[MacOS] [Cr88] follow up: create_dmg fails.
3 participants