Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brave Today: popup menu for publisher name which disables publisher #7104

Merged
merged 3 commits into from
Nov 10, 2020

Conversation

petemill
Copy link
Member

@petemill petemill commented Nov 10, 2020

Resolves brave/brave-browser#12608

image

Has a storybook page

Also contains small typography and spacing fixes as finessed with @karenkliu

Submitter Checklist:

Test Plan:

On issue

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@petemill petemill self-assigned this Nov 10, 2020
onClick={toggleMenu}
innerRef={triggerElementRef}
aria-haspopup='true'
aria-expanded={isMenuOpen ? 'true' : 'false'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I might be wrong but won’t this translate appropriately if you just set the property to the variable? Ex it handles bool to string conversion

Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes lgtm

@petemill
Copy link
Member Author

petemill commented Nov 10, 2020

CI all ✅ apart from macOS which had some random missing file failure. Restarting it clean.

edit: seems to be successful now

@petemill petemill merged commit 6f3082f into master Nov 10, 2020
@petemill petemill deleted the brave-today-publisher branch November 10, 2020 20:35
@petemill petemill added this to the 1.18.x - Nightly milestone Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brave Today publishers should be easily disabled
2 participants