Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes follow up to #11057: Implement client ads pacing mechanism - 1.15.x #6637

Merged
merged 1 commit into from
Sep 17, 2020
Merged

Fixes follow up to #11057: Implement client ads pacing mechanism - 1.15.x #6637

merged 1 commit into from
Sep 17, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Sep 14, 2020 •
edited by kjozwiak
Loading

Uplift of #6614
Resolves brave/brave-browser#11643

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.15.x - Beta milestone Sep 14, 2020
@tmancey tmancey requested a review from a team September 14, 2020 17:53
@tmancey tmancey self-assigned this Sep 14, 2020
kjozwiak
kjozwiak approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.15.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6614 (comment).

@kjozwiak kjozwiak merged commit 5f4e09e into 1.15.x Sep 17, 2020
@kjozwiak kjozwiak deleted the issues/11643-1.15.x branch September 17, 2020 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@tmancey tmancey

Labels
bug feature/ads
Projects
None yet
Milestone
1.15.x - Release #1
Development

Successfully merging this pull request may close these issues.
2 participants
@tmancey @kjozwiak