Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't fire notifications on initialization (uplift to 1.12.x) #6147

Merged
merged 1 commit into from
Jul 23, 2020
Merged

don't fire notifications on initialization (uplift to 1.12.x) #6147

merged 1 commit into from
Jul 23, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Jul 21, 2020 •
edited by kjozwiak
Loading

Uplift of #6126
fix brave/brave-browser#9481

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team July 21, 2020 15:51
@brave-builds brave-builds self-assigned this Jul 21, 2020
@brave-builds brave-builds added this to the 1.12.x - Beta milestone Jul 21, 2020
@bsclifton
Copy link
Member

bsclifton commented Jul 22, 2020 •
edited
Loading

CI need to be re-run after brave/brave-browser#10844 is merged. gn check isn't in 1.12 or 1.11 (yet) and unfortunately failing this fails the build

kjozwiak
kjozwiak approved these changes Jul 23, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.12.x approved after deliberating with @brave/uplift-approvers. QA has also verified the PR on Nightly as per #6126 (comment).

@kjozwiak kjozwiak merged commit 600235a into 1.12.x Jul 23, 2020
@kjozwiak kjozwiak deleted the pr6126_issues/9481_1.12.x branch July 23, 2020 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.12.x - Release #1
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @bsclifton @kjozwiak @brave-browser-releases