Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds pending status for uphold #6140

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Adds pending status for uphold #6140

merged 1 commit into from
Jul 21, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jul 21, 2020

Resolves brave/brave-browser#10023

Submitter Checklist:

Test Plan:

  • enable rewards
  • claim grant
  • click verify wallet
  • create new account
  • when you are redirected back to rewards click on Verify wallet
  • make sure that you see dropdown telling you that you are in pending status

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc requested a review from a team July 21, 2020 13:40
@NejcZdovc NejcZdovc self-assigned this Jul 21, 2020
@NejcZdovc NejcZdovc requested review from emerick and zenparsing and removed request for a team July 21, 2020 13:40
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LaurenWags
Copy link
Member

Verified passed with

Brave | 1.14.6 Chromium: 84.0.4147.105 (Official Build) nightly (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-07-31 at 7 27 36 AM

Screen Shot 2020-07-31 at 7 28 08 AM

  • Confirmed if you then go add personal information as required for Uphold (name, phone number etc) but do not verify your email, you will still get the Pending popup when clicking on "Verify Wallet":

Screen Shot 2020-07-31 at 7 48 51 AM

Screen Shot 2020-07-31 at 7 48 33 AM

  • Confirmed if you then verify your email as required, you will now get the "Connected" popup:

Screen Shot 2020-07-31 at 7 51 36 AM

Screen Shot 2020-07-31 at 7 51 21 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pending state in the UI for Uphold
4 participants