Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade patches from Chromium 84.0.4147.85 to Chromium 84.0.4147.89 (1.11.x). #6069

Merged
merged 1 commit into from
Jul 14, 2020

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Jul 13, 2020

Fixes brave/brave-browser#10714
Related PR: brave/brave-browser#10721

Uplift from #6066

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Upgrade patches from Chromium 84.0.4147.85 to Chromium 84.0.4147.89
@kjozwiak
Copy link
Member

Looks like audit-deps failed on every platform due to lodash which is a known issue and has been resolved in 1.12.x and 1.13.x. Doesn't block uplift.

Restarting Android as test-unit failed due to not being able to find/attach a device to complete the test runs as per https://ci.brave.com/job/pr-brave-browser-84.0.4147.89-1.11.x/3/execution/node/606/log/.

20:30:23  NoDevicesError: No devices attached.

Looks like audit-network failed on Linux as per https://ci.brave.com/job/pr-brave-browser-84.0.4147.89-1.11.x/3/execution/node/475/log/ which is a known intermittent issue and doesn't block uplift.

@kjozwiak kjozwiak added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jul 14, 2020
@kjozwiak
Copy link
Member

Remaining issue on Android is due to npm run audit_deps failing because of lodash which is a known issue in 1.11.x and doesn't block uplift.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 37830a1 into 1.11.x Jul 14, 2020
@kjozwiak kjozwiak deleted the 84.0.4147.89-1.11.x branch July 14, 2020 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/run-network-audit Run network-audit CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants