Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait for initial rewards API parameter fetch from server #6002

Merged
merged 1 commit into from
Jul 8, 2020

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Jul 5, 2020

Resolves brave/brave-browser#10438

Submitter Checklist:

Test Plan:

See brave/brave-browser#10438 for original test cases.

Test Case: AC amount drop down is fully populated after enabling rewards

  • Launch with a clean profile, pointed to staging.
  • Navigate to brave://rewards.
  • Enable rewards.
  • Scroll down to AC settings.
    • Verify that a valid amount is display in the AC amount selection.
  • Click the AC amount drop down arrow.
    • Verify that a list of valid selections are displayed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@zenparsing zenparsing self-assigned this Jul 5, 2020
@zenparsing zenparsing force-pushed the ksmith-wait-for-api-params branch 3 times, most recently from e0be478 to eb4fff7 Compare July 5, 2020 22:18
@zenparsing
Copy link
Collaborator Author

Updated PR so that callbacks are always run with prefs data, even if the fetch fails for some reason.

@zenparsing zenparsing added CI/skip-android Do not run CI builds for Android CI/skip-windows labels Jul 7, 2020
@zenparsing zenparsing removed CI/skip-android Do not run CI builds for Android CI/skip-windows labels Jul 7, 2020
@zenparsing zenparsing added this to the 1.13.x - Nightly milestone Jul 8, 2020
@zenparsing zenparsing merged commit 77867ef into master Jul 8, 2020
@zenparsing zenparsing deleted the ksmith-wait-for-api-params branch July 8, 2020 20:32
brave-builds pushed a commit that referenced this pull request Jul 9, 2020
NejcZdovc pushed a commit that referenced this pull request Jul 9, 2020
@LaurenWags
Copy link
Member

While testing on Nightly, issues were encountered that are most likely specific to code changes in 1.12.x and 1.13.x. Since the fix for this is intended for 1.11.x, this was tested with a PR build and notes can be found here: #6050 (comment)

A follow up issue was logged to address remaining 1.11.x issues as well as problems seen while testing on Nightly: brave/brave-browser#10717

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants