Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same location/omnibox color in light/dark mode with private #5899

Merged
merged 1 commit into from
Jun 20, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Jun 18, 2020

Resolves brave/brave-browser#9945

Screen Shot 2020-06-18 at 10 44 40 PM

Screen Shot 2020-06-18 at 10 45 02 PM

Screen Shot 2020-06-19 at 6 58 13 AM

Screen Shot 2020-06-19 at 6 58 29 AM

Submitter Checklist:

Test Plan:

  1. Open Private window
  2. Change theme setting and check Private window always uses same color for address bar

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong added this to the 1.12.x - Nightly milestone Jun 18, 2020
@simonhong simonhong self-assigned this Jun 18, 2020
Copy link

@karenkliu karenkliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonhong Can you add a screenshot of the address bar in its un-focused state?

Copy link

@karenkliu karenkliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Address bar background color does not change in private mode when dark theme is enabled
2 participants