Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stats ping api key a header #5823

Merged
merged 1 commit into from
Jun 12, 2020
Merged

Make stats ping api key a header #5823

merged 1 commit into from
Jun 12, 2020

Conversation

kkuehlz
Copy link
Contributor

@kkuehlz kkuehlz commented Jun 11, 2020

This will give brave-core parity with iOS.

Resolves brave/brave-browser#10230

Resolves

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

This will give brave-core parity with iOS.

Resolves brave/brave-browser#10230
@kkuehlz kkuehlz added this to the 1.12.x - Nightly milestone Jun 11, 2020
@kkuehlz kkuehlz requested a review from emerick June 12, 2020 04:22
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kkuehlz kkuehlz merged commit 687b913 into master Jun 12, 2020
@kkuehlz kkuehlz deleted the api_key_header branch June 12, 2020 15:36
@kjozwiak
Copy link
Member

kjozwiak commented Jul 7, 2020

Verification PASSED on macOS 10.15.5 x64 Catalina using the following build:

Brave | 1.12.77 Chromium: 84.0.4147.68 (Official Build) nightly (64-bit)
-- | --
Revision | e7b7234037639b407e69c5428c891ce018cd6c0d-refs/branch-heads/4147@{#772}
OS | macOS Version 10.15.5 (Build 19F101)

Ensured that x-brave-api-key was being used in the https://laptop-updates.brave.com/1/usage ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set x-brave-api-key in stats ping header
3 participants