Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Travis unit tests #533

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Fixing Travis unit tests #533

merged 1 commit into from
Oct 1, 2018

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Oct 1, 2018 •
edited
Loading

Fixes: brave/brave-browser#1370

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@ryanml ryanml self-assigned this Oct 1, 2018
@ryanml ryanml changed the title WIP: Fixing Travis unit tests Fixing Travis unit tests Oct 1, 2018
cezaraugusto
cezaraugusto approved these changes Oct 1, 2018
View reviewed changes
Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

bsclifton
bsclifton approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! 10/10 A++++

@cezaraugusto cezaraugusto merged commit 5eec78b into brave:master Oct 1, 2018
ryanml pushed a commit that referenced this pull request Oct 1, 2018
@cezaraugusto @ryanml
Merge pull request #533 from ryanml/fix-1370
0011291 
Fixing Travis unit tests
ryanml pushed a commit that referenced this pull request Oct 1, 2018
@cezaraugusto @ryanml
Merge pull request #533 from ryanml/fix-1370
4cc048e 
Fixing Travis unit tests
@ryanml
Copy link
Contributor Author

ryanml commented Oct 1, 2018

master: 5eec78b
0.55.x: 0011291
0.56.x: 4cc048e

@bbondy bbondy added this to the 0.55.x - Release milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@yrliou yrliou yrliou approved these changes

@bsclifton bsclifton bsclifton approved these changes

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
0.55.x - Release
Development

Successfully merging this pull request may close these issues.

Travis CI unit tests failing on brave-core master
5 participants
@ryanml @cezaraugusto @yrliou @bsclifton @bbondy