WIP: IPFS extension #425

drbh · 2018-09-08T21:11:46Z

Fixes brave/brave-browser#1042

PR based on work done on Tor like: #316

Submitter Checklist:

Submitted a ticket for my issue if one did not already exist.
Used Github auto-closing keywords in the commit message.
Added/updated tests for this change (for new code or code which already has tests).
Ran git rebase -i to squash commits (if needed).
Tagged reviewers and labelled the pull request as needed.
Request a security/privacy review as needed.
Add appropriate QA labels (QA/Needed or QA/No-QA-Needed) to include the closed issue in milestone

Test Plan:

Extension download and
- installation
- Start with a clean profile
- Launch Brave
- Visit chrome://components
- Verify that Ipfs Client Updater is listed and version number is not 0.0.0.0
- Verify that name of component contains platform identifier (Windows/Mac/Linux)
- Command-line switch to disable extension
Start with a clean profile
- Launch Brave with --disable-ipfs-client-updater-extension
- Visit chrome://components and verify that Ipfs Client Updater is not listed

Reviewer Checklist:

New files have MPL-2.0 license header.
Request a security/privacy review as needed.
Adequate test coverage exists to prevent regressions
Verify test plan is specified in PR before merging to source

drbh · 2018-09-08T21:16:43Z

@emerick follow up on brave/brave-core-crx-packager#23

browser/extensions/BUILD.gn

browser/extensions/brave_ipfs_client_updater.cc

emerick · 2018-09-10T14:15:59Z

browser/extensions/brave_ipfs_client_updater.h

+
+#if defined(OS_WIN)
+const std::string kIpfsClientComponentName("Brave Ipfs Client Updater (Windows)");
+const std::string kIpfsClientComponentId("client-component");


The should be the actual component ID, as listed in chrome://extensions.

emerick · 2018-09-10T14:16:12Z

browser/extensions/brave_ipfs_client_updater.h

+
+#elif defined(OS_MACOSX)
+const std::string kIpfsClientComponentName("Brave Ipfs Client Updater (Mac)");
+const std::string kIpfsClientComponentId("client-component");


See comment above.

emerick · 2018-09-10T14:16:23Z

browser/extensions/brave_ipfs_client_updater.h

+
+#elif defined(OS_LINUX)
+const std::string kIpfsClientComponentName("Brave Ipfs Client Updater (Linux)");
+const std::string kIpfsClientComponentId("client-component");


See comment above.

emerick · 2018-09-10T14:20:32Z

test/data/ipfs-client-updater/ipfs-client-updater-linux.pem

@@ -0,0 +1,28 @@
+-----BEGIN PRIVATE KEY-----


Just double-checking: the PEM files used for tests should be unique and not used in any production code. Can you confirm? Thanks!

the private key I used is a copy of the private key used in the Tor test implementation at https://github.com/brave/brave-core/blob/master/test/data/tor-client-updater/tor-client-updater-mac.pem

emerick · 2018-09-10T14:33:27Z

browser/extensions/brave_ipfs_client_updater_browsertest.cc

+
+using extensions::ExtensionBrowserTest;
+
+const std::string kIpfsClientUpdaterComponentTestId("");


The test extension's component ID should be here, as listed in chrome://extensions.

I did not include any component ID since I wasn't sure if I built them from a private key that I generated (not the official one) they would resolve to a different id...

the private key I used is a copy of the private key used in the Tor test implementation at https://github.com/brave/brave-core/blob/master/test/data/tor-client-updater/tor-client-updater-mac.pem

emerick · 2018-09-10T14:36:30Z

browser/extensions/brave_extension_provider.cc

    // Brave Ipfs Client Updater (Mac)
-    " - - - - - - - - - - - - - - - - - - ",
+    "ngicbhhaldfdgmjhilmnleppfpmkgbbk",


This is the same ID as the Tor Client Updater. Typo?

emerick · 2018-09-10T14:36:44Z

browser/extensions/brave_extension_provider.cc

@@ -98,7 +98,7 @@ bool BraveExtensionProvider::IsVetted(const Extension* extension) {
    // Test ID: Brave Tor Client Updater
    "ngicbhhaldfdgmjhilmnleppfpmkgbbk"
    // Test ID: Brave Ipfs Client Updater
-    " - - - - - - - - - - - - - - - - - - "
+    "ngicbhhaldfdgmjhilmnleppfpmkgbbk"


This is the same ID as the Tor Client Updater. Typo?

drbh · 2018-10-10T04:41:49Z

@emerick or @bbondy could someone help me sort out the private key issue and figure out the correct component ids in browser/extensions/brave_extension_provider.cc.

I'm confused about what keys I should use, and how to generate the component ID for the extension aside from the test case.

bbondy · 2018-10-14T03:38:22Z

@drbh in a bit of a crunch since we're releasing the first version on release channel this coming week. But @emerick will get to this after that. Sorry for the delay.

drbh · 2018-12-01T22:20:46Z

bump.

Is there still interest in integrating IPFS natively into Brave - if there is more dev work I can help with for this PR please let me know.

bbondy · 2018-12-04T04:06:44Z

Thanks for your patience, we need to decide how we want to offer the feature, but we will re-use this work. We'll take a look soon. I think we want to package a daemon like we do with Tor but not have it enabled by default. We could prompt to enable it if the user does a certain action like trying to load ipfs:// for example.

bbondy · 2018-12-04T04:08:40Z

We also want to manage the daemon process like we do for Tor.

drbh · 2018-12-08T00:25:51Z

@bbondy as to packaging the daemon there is already CRX support in the crx packager repo here: https://github.com/brave/brave-core-crx-packager/tree/master/scripts

How do we go about managing the daemon process like Tor?

Is the process managed solely by the files located here:
https://github.com/brave/brave-core/tree/master/browser/tor

I agree we should not enable IPFS by default but only when a user requests it's service with ipfs://

bbondy · 2018-12-10T15:38:58Z

@darkdh would you mind sharing some wisdom / guidance?

darkdh · 2018-12-10T21:29:50Z

as we discussed in slack DM, see
a3d7571

bbondy · 2018-12-11T03:56:43Z

@drbh is this something you'd be interested in working on?

drbh · 2018-12-11T04:59:31Z

@bbondy yes I would love to! I undoubtedly will need help down the line, but I can for sure get this started! 😄

bbondy · 2019-04-18T17:30:31Z

Closing this since I think this is handled by feature detection within the Chrome extension now.

lidel · 2019-04-19T10:39:36Z

Context for drive-by readers:

We are parking work on embedding go-ipfs binary for now, and focus on shipping embedded js-ipfs as noted in brave/brave-browser#819 (comment)

Details about chrome.sockets feature-detection can be tracked in ipfs/ipfs-companion#664

drbh added 2 commits September 8, 2018 14:01

base files for ipfs CRX mgmt

6edc977

typo fix, added keys for test

2ca839e

jasonrsadler requested a review from emerick September 9, 2018 00:38

jasonrsadler assigned drbh Sep 9, 2018

emerick requested changes Sep 10, 2018

View reviewed changes

emerick requested a review from bbondy September 10, 2018 14:37

drbh added 2 commits September 10, 2018 13:20

update alphabetical order

31b750e

Merge branch 'master' of https://github.com/brave/brave-core

abfad94

bbondy changed the title ~~Ipfs ext~~ WIP: Ipfs ext Sep 29, 2018

lidel mentioned this pull request Sep 30, 2018

Update Ipfs client via component extension brave/brave-browser#1042

Closed

drbh added 2 commits October 9, 2018 23:48

resolve conflicts for update

8f06dc4

fix wild card match in brave_ipfs_client_updater

3af3c16

Merge branch 'master' into ipfs-ext

0455181

drbh changed the title ~~WIP: Ipfs ext~~ WIP: IPFS extension Nov 27, 2018

bbondy closed this Apr 18, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: IPFS extension #425

WIP: IPFS extension #425

drbh commented Sep 8, 2018 •

edited by emerick

Loading

drbh commented Sep 8, 2018

emerick Sep 10, 2018

emerick Sep 10, 2018

emerick Sep 10, 2018

emerick Sep 10, 2018

drbh Sep 10, 2018

emerick Sep 10, 2018

drbh Sep 10, 2018

emerick Sep 10, 2018 •

edited

Loading

emerick Sep 10, 2018 •

edited

Loading

drbh commented Oct 10, 2018

bbondy commented Oct 14, 2018

drbh commented Dec 1, 2018

bbondy commented Dec 4, 2018

bbondy commented Dec 4, 2018

drbh commented Dec 8, 2018

bbondy commented Dec 10, 2018

darkdh commented Dec 10, 2018

bbondy commented Dec 11, 2018

drbh commented Dec 11, 2018

bbondy commented Apr 18, 2019

lidel commented Apr 19, 2019


		using extensions::ExtensionBrowserTest;

		const std::string kIpfsClientUpdaterComponentTestId("");

WIP: IPFS extension #425

WIP: IPFS extension #425

Conversation

drbh commented Sep 8, 2018 • edited by emerick Loading

Submitter Checklist:

Test Plan:

Reviewer Checklist:

drbh commented Sep 8, 2018

emerick Sep 10, 2018

Choose a reason for hiding this comment

emerick Sep 10, 2018

Choose a reason for hiding this comment

emerick Sep 10, 2018

Choose a reason for hiding this comment

emerick Sep 10, 2018

Choose a reason for hiding this comment

drbh Sep 10, 2018

Choose a reason for hiding this comment

emerick Sep 10, 2018

Choose a reason for hiding this comment

drbh Sep 10, 2018

Choose a reason for hiding this comment

emerick Sep 10, 2018 • edited Loading

Choose a reason for hiding this comment

emerick Sep 10, 2018 • edited Loading

Choose a reason for hiding this comment

drbh commented Oct 10, 2018

bbondy commented Oct 14, 2018

drbh commented Dec 1, 2018

bbondy commented Dec 4, 2018

bbondy commented Dec 4, 2018

drbh commented Dec 8, 2018

bbondy commented Dec 10, 2018

darkdh commented Dec 10, 2018

bbondy commented Dec 11, 2018

drbh commented Dec 11, 2018

bbondy commented Apr 18, 2019

lidel commented Apr 19, 2019

drbh commented Sep 8, 2018 •

edited by emerick

Loading

emerick Sep 10, 2018 •

edited

Loading

emerick Sep 10, 2018 •

edited

Loading