Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uplift Disable opening Tor options in guest window to 1.3.x #4189

Merged
merged 1 commit into from
Dec 10, 2019

Conversation

yrliou
Copy link
Member

@yrliou yrliou commented Dec 9, 2019

Disable opening Tor options in guest window
@yrliou yrliou added this to the 1.3.x - Dev milestone Dec 9, 2019
@yrliou yrliou requested a review from a team December 9, 2019 22:33
@yrliou yrliou requested a review from bridiver as a code owner December 9, 2019 22:33
@yrliou yrliou self-assigned this Dec 9, 2019
@yrliou
Copy link
Member Author

yrliou commented Dec 10, 2019

CI failed at test-install which is unrelated to this PR,

11:07:07  + '[' = release ']'
11:07:07  /Users/jenkins/jenkins/workspace/ld-pr_disable_tor_in_guest_1.3.x@tmp/durable-416a7239/script.sh: line 2: [: =: unary operator expected
11:07:07  ++ tr '[:lower:]' '[:upper:]'
11:07:07  + CHANNEL_CAPITALIZED=
11:07:07  + '[' = release ']'
11:07:07  /Users/jenkins/jenkins/workspace/ld-pr_disable_tor_in_guest_1.3.x@tmp/durable-416a7239/script.sh: line 3: [: =: unary operator expected
11:07:07  + BROWSER='Brave Browser '
11:07:07  + OUT_DIR=/Users/jenkins/jenkins/workspace/ld-pr_disable_tor_in_guest_1.3.x/src/out/
11:07:07  + '[' = true ']'
11:07:07  /Users/jenkins/jenkins/workspace/ld-pr_disable_tor_in_guest_1.3.x@tmp/durable-416a7239/script.sh: line 5: [: =: unary operator expected
11:07:07  + hdiutil attach -nobrowse '/Users/jenkins/jenkins/workspace/ld-pr_disable_tor_in_guest_1.3.x/src/out//Brave Browser .dmg'
11:07:07  hdiutil: attach failed - No such file or directory

@yrliou
Copy link
Member Author

yrliou commented Dec 10, 2019

Verified the test plan specified in #4155 is working on latest nightly (v1.4.15).

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.3.x approved after deliberating with @brave/uplift-approvers. As per #4189 (comment), the only CI/Jenkins failure is not due to this specific PR. Please make sure that all the correct labels are being used and the associated issue(s) are moved into the correct milestone.

@yrliou yrliou merged commit 5f47133 into 1.3.x Dec 10, 2019
@yrliou yrliou deleted the disable_tor_in_guest_1.3.x branch December 10, 2019 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants